1568500 - about:logins - password not revealed when pressing the button/icon for it

Status: RESOLVED DUPLICATE of bug 1565687

(Firefox :: about:logins, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: lockwise_PasswordEye.gif

Affected versions

• 69.0b7, 70.0a1 (2019-07-23) ;

Affected platforms

• Windows 10, macOS 10.14, Ubuntu 18.04

Steps to reproduce

1. Launch Firefox and save at least 1 user/password to any website;
2. Access about:logins;
3. Click on the entry from the list;
4. Click on the eye symbol to reveal/hide the password;
5. Repeat step 4;

Expected result

• password is revealed;

Actual result

• password is not revealed;

Regression range

• First bad: build_date: 2019-07-05 08:21:01.413000 changeset: b7030ce607ec56690829e8fb6dbcd27dd54a044c
• Last good: build_date: 2019-07-04 23:49:36.024000 changeset: ac50a7bd09b0a9262eed73f9dee2ffbd0e1a33b2
• Pushlog: URL
• Potential regressor: 1558242 looks the likely candidate for this.

Additional notes

• attached recording with the issue;

Comment 1

[Cristian Fogel [:cfogel]]

Hi Jared, mind taking a look and confirming if it's the case?
Thanks!

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This was fixed by bug 1565687.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Are you sure that this was broken in Nightly (2019-07-23)? I can't reproduce it in 70.0a1 (2019-07-24) and bug 1565687 added tests to make sure this doesn't break again. Can you please test again?

Comment 4

[Cristian Fogel [:cfogel]]

Re-checked with a fresh setup and indeed it is fixed on both (2019-07-23) and (2019-07-24) on the mentioned platforms.