1565690 - Prefer image aspect ratio to inferred aspect ratio.

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

This would fix all the regressions from bug 1547231.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1565690 - When inferring an aspect ratio from an image's width and height attribute, only honor it if we don't have the real image aspect-ratio. r=dholbert

Since people like to get wrong attribute values on their images, see the
regressions from bug 1547231.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa0016d9f9f8
When inferring an aspect ratio from an image's width and height attribute, only honor it if we don't have the real image aspect-ratio. r=dholbert

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17815 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aa0016d9f9f8

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 10

[Boris Zbarsky [:bzbarsky]]

Should this lead to a spec change too? Or did it?

Comment 11

[Emilio Cobos Álvarez [:emilio]]

I wanted to wait for it to get a spec change before turning it on on release, see near the end of https://github.com/WICG/intrinsicsize-attribute/issues/16.