1547231 - Map the width and height attribute of images to aspect-ratio

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

This is fantasai's and Jenn's proposal in:

https://github.com/mozilla/standards-positions/issues/129#issuecomment-472635914

I think it's worth trying it, at least on Nightly / Beta, and maybe also collect telemetry for when it changes layout on release.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1547231 - Add an internal aspect-ratio CSS property. r=dholbert,#style

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1547231 - Map width and height on image-ish elements to aspect-ratio. r=dholbert

Depends on D29037

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1547231 - Make mapped aspect-ratio get reflected in images. r=dholbert

It works!

Depends on D29038

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Have some patches, the last one of which is a complete hack. Should do a bit more cleanup before sending them for review, but I uploaded them regardless. I didn't have power so I didn't want to touch many headers, thus the hacky approach.

May finish it up next week. I'll also push to try to see if there's something obviously broken.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7fd34a8c655
Add an internal aspect-ratio CSS property. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e314c697fe89
Map width and height on image-ish elements to aspect-ratio. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/fd9cb42cee29
Make mapped aspect-ratio get reflected in images. r=dholbert

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e7fd34a8c655
https://hg.mozilla.org/mozilla-central/rev/e314c697fe89
https://hg.mozilla.org/mozilla-central/rev/fd9cb42cee29

Comment 7

[Boris Zbarsky [:bzbarsky]]

So this affects embed, iframe, marquee, object, table, and video, in addition to actual images (img and input type="image"). Is that expected?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Replied on IRC, but yes, we only look at the property in nsImageFrame so it's not an issue (it does affect <img>, <input type="image">, <object> with an image, ...).

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17709 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 11

[Boris Zbarsky [:bzbarsky]]

Is there a bug tracking flipping the pref in release?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I think this should be fine to turn on on release, though I wanted to get the spec situation sorted out, see https://github.com/WICG/intrinsicsize-attribute/issues/16#issuecomment-515035191 and following.