1565714 - Disabled breakpoint numbers should be a shade of blue

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

We try and polish every detail of breakpoints down to the color of the breakpoint line number text color. One case we do not handle well is disabled breakpoints, which are the active line number grey. We should update it to be a blue that is darker than disabled breakpoints, which will be slightly more refined.

Comment 1

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-07-12 at 12.34.00 PM.png

Comment 2

[Krishnal Ciccolella]

Attachment: 2019-07-14-11-44-32.png

I would like to try my hand at this.

I noticed when disabling breakpoints, they appear white though.

Comment 3

[Krishnal Ciccolella]

Attachment: Bug 1565714 - Disabled breakpoint numbers should be a shade of blue r=jlast

In Breakpoint.js I added an if else statement to the function addBreakpoint() to add/remove class "breakpoint-disabled" depending on the value of breakpoint.disabled. I then added a selector in Editor.css to set color: blue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56582e290c63
Disabled breakpoint numbers should be a shade of blue

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/56582e290c63