1565894 - Setting text encoding to "Japanese" in TB's compose window doesn't work

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1565888 +++

See bug 1565888 comment #5:
[4232, Main Thread] WARNING: 'NS_FAILED(rv)', file c:/mozilla-source/comm-central/editor/libeditor/TextEditor.cpp, line 215
*** Failed to get string japanese in bundle: chrome://communicator/content/labelsencodings.properties
JavaScript error: chrome://global/content/elements/stringbundle.js, line 45: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]

TextEditor.cpp, line 215 is EditorBase::SetDocumentCharacterSet(). So it looks like more work is required here, I'll file a new bug. The resulting message is stored in UTF-8 :-(

Comment 1

[Jorg K (CEST = GMT+2)]

Masatoshi-san, could you advise us here. Should we set the charset to Shift_JIS here? What about people who want ISO-2022-JP? Or should we hand-roll the menu and replace Japanese with the original three options Shift_JIS, ISO-2022-JP and EUC-JP?

Comment 2

[Jorg K (CEST = GMT+2)]

The spot to do it is here in fixCharset():
https://searchfox.org/comm-central/rev/e9439ba2501591b8d9890bd6973d74bd3c06da3f/mailnews/compose/src/nsMsgCompose.cpp#1484

Note that we did some charset-specific stuff there already:
https://hg.mozilla.org/comm-central/rev/71c50d951771a03efa9f2ec5731cef0846fa52d1#l1.10

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1565894-fixCharset.patch - WIP

Uff, this doesn't work, the resulting message is still in UTF-8 :-(

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1565894-fixCharset.patch (v2)

It's still unclear how people would get ISO-2022-JP.

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Jorg K (GMT+2) from comment #1)

Masatoshi-san, could you advise us here. Should we set the charset to Shift_JIS here? What about people who want ISO-2022-JP? Or should we hand-roll the menu and replace Japanese with the original three options Shift_JIS, ISO-2022-JP and EUC-JP?

Sorry, I don't know. Firefox doesn't have to fallback to other encodings than Shift_JIS for Japanese.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9078010 [details] [diff] [review]
1565894-fixCharset.patch (v2)

I guess we need to hand-roll the menu here.

Comment 7

[Masatoshi Kimura [:emk]]

I re-read the discussion in bug 1543077. According to the discussion, I think TB can use "ISO-2022-JP" instead of "Shift_JIS" here.

Comment 8

[Jorg K (CEST = GMT+2)]

Right, see bug 1543077 comment #33 and above.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1565894-make-Japanese-ISO-2022-JP.patch

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: 1565894-make-Japanese-ISO-2022-JP.patch

Why do I always mistype "Japanese" as "Japanse" or "Japaneses" :-(

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/20a4ced7e73f
Replace Japanese with ISO-2022-JP in SetDocumentCharacterSet(). r=mkmelin

Comment 12

[Jorg K (CEST = GMT+2)]

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/da9e718d81a089661c7aeffe4dab41b516d86bdc