Closed Bug 1565894 Opened 3 months ago Closed 3 months ago

Setting text encoding to "Japanese" in TB's compose window doesn't work

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set

Tracking

(thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: jorgk, Assigned: jorgk)

Details

Attachments

(1 file, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #1565888 +++

See bug 1565888 comment #5:
[4232, Main Thread] WARNING: 'NS_FAILED(rv)', file c:/mozilla-source/comm-central/editor/libeditor/TextEditor.cpp, line 215
*** Failed to get string japanese in bundle: chrome://communicator/content/labelsencodings.properties
JavaScript error: chrome://global/content/elements/stringbundle.js, line 45: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]

TextEditor.cpp, line 215 is EditorBase::SetDocumentCharacterSet(). So it looks like more work is required here, I'll file a new bug. The resulting message is stored in UTF-8 :-(

Masatoshi-san, could you advise us here. Should we set the charset to Shift_JIS here? What about people who want ISO-2022-JP? Or should we hand-roll the menu and replace Japanese with the original three options Shift_JIS, ISO-2022-JP and EUC-JP?

Flags: needinfo?(VYV03354)
Attached patch 1565894-fixCharset.patch - WIP (obsolete) — Splinter Review

Uff, this doesn't work, the resulting message is still in UTF-8 :-(

Assignee: nobody → jorgk
Attached patch 1565894-fixCharset.patch (v2) (obsolete) — Splinter Review

It's still unclear how people would get ISO-2022-JP.

Attachment #9078010 - Flags: review?(VYV03354)

(In reply to Jorg K (GMT+2) from comment #1)

Masatoshi-san, could you advise us here. Should we set the charset to Shift_JIS here? What about people who want ISO-2022-JP? Or should we hand-roll the menu and replace Japanese with the original three options Shift_JIS, ISO-2022-JP and EUC-JP?

Sorry, I don't know. Firefox doesn't have to fallback to other encodings than Shift_JIS for Japanese.

Flags: needinfo?(VYV03354)
Attachment #9077995 - Attachment is obsolete: true
Comment on attachment 9078010 [details] [diff] [review]
1565894-fixCharset.patch (v2)

I guess we need to hand-roll the menu here.
Attachment #9078010 - Flags: review?(VYV03354)

I re-read the discussion in bug 1543077. According to the discussion, I think TB can use "ISO-2022-JP" instead of "Shift_JIS" here.

Right, see bug 1543077 comment #33 and above.

Attachment #9078010 - Attachment is obsolete: true
Attachment #9078820 - Flags: review?(mkmelin+mozilla)

Why do I always mistype "Japanese" as "Japanse" or "Japaneses" :-(

Attachment #9078820 - Attachment is obsolete: true
Attachment #9078820 - Flags: review?(mkmelin+mozilla)
Attachment #9078822 - Flags: review?(mkmelin+mozilla)
Attachment #9078822 - Flags: approval-comm-beta+
Attachment #9078822 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 70.0
Version: Trunk → 69
Status: NEW → ASSIGNED
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/20a4ced7e73f
Replace Japanese with ISO-2022-JP in SetDocumentCharacterSet(). r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.