Closed Bug 1565962 Opened 8 months ago Closed 8 months ago

Place console sidebar in the same Grid as other webconsole main components

Categories

(DevTools :: Console, task, P1)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [console-editor-mvp])

Attachments

(1 file)

With Bug 1521452 landed, we should be able to get rid of the splitbox and place the sidebar in the main CSS grid we use for the console layout.

Blocks: 1565017

Since we now have a GridElementWidthResizer element, we can
get rid of the SplitBox wrapping the SideBar, and have all
major elements as child of the App element, controlled by
a CSS Grid.

This makes it easy to change the console layout when toggling
the editor mode (re-ordering element in JS, changing the CSS
grid templates, and placing the element in different areas).
This also means we can take advantage of subgrid to align
the sidebar toolbar with the filter bar for example.

As the part of the stylesheet dedicated to layout grew, it
made sense to have it all in a separate stylesheet, App.css,
that lives next to the App component.

Whiteboard: [console-editor-mvp]
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b3664109ecc
Refactor webconsole layout. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.