1566011 - Create sub component for manifestItem

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P1)

Description

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

We need to create a view component for the manifest key:value pairs to show in a table.

Scope:

• Create a new view sub component of the main manifest component that renders a table with placeholders

  • TABLE GRID: [ ICON - 24 x 24][ LABEL / KEY - 320px max ][ VALUE - rest of width]

• Add test

  • The table is rendered correctly in the main view of the manifest

Add second component for `ManifestTableEmpty and move fluent string from page to it.

Comment 1

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Attachment: Bug 1566011 renaming the layout folder to routing + PageContainer component to PageSwitcher, Part 1, r=ladybenko!

First part is renaming the layout folder to routing as discussed as well as the PageContainer component to PageSwitcher.

Comment 2

[Belén [:ladybenko]]

About the ManifestTableEmpty part, I think it kind of belongs to https://bugzilla.mozilla.org/show_bug.cgi?id=1566007, which will handle "yes we have a manifest" vs "no, we don't have one".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3be7294458d
renaming the layout folder to routing + PageContainer component to PageSwitcher, Part 1, r=ladybenko

Comment 4

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Attachment: Bug 1566011 Create sub component for manifestItem (part 2), r=ladybenko!

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d3be7294458d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82634a1a2374
Create sub component for manifestItem (part 2), r=ladybenko,fluent-reviewers,flod

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 82634a1a2374 (bug 1566011) for devtools failures at browser/base/content/test/static/browser_parsable_css.js

Backout: https://hg.mozilla.org/integration/autoland/rev/d359a7ccf59750a2a2e145054227b72239cc9615

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=262651520&revision=82634a1a23743a53cc38bee42e550cc01b76e1ca

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262651520&repo=autoland&lineNumber=1076

[task 2019-08-21T11:59:14.810Z] 11:59:14 INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js

task 2019-08-21T11:59:15.837Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 746}]
[task 2019-08-21T11:59:15.841Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 757}]
[task 2019-08-21T11:59:15.841Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 761}]
[task 2019-08-21T11:59:15.841Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 766}]
[task 2019-08-21T11:59:15.841Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 771}]
[task 2019-08-21T11:59:15.841Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 775}]
[task 2019-08-21T11:59:15.842Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 779}]
[task 2019-08-21T11:59:15.843Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 784}]
[task 2019-08-21T11:59:15.844Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 789}]
[task 2019-08-21T11:59:15.844Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 803}]
[task 2019-08-21T11:59:15.844Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 808}]
[task 2019-08-21T11:59:15.850Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 813}]
[task 2019-08-21T11:59:15.850Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.3086888068801318" line: 817}]
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Error in parsing value for ‘display’. Declaration dropped." {file: "resource://devtools/client/debugger/src/components/ProjectSearch.css?always-parse-css-0.3086888068801318" line: 93}]
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - Console message: [JavaScript Warning: "Unknown property ‘-moz-border-radius’. Declaration dropped." {file: "chrome://devtools/content/shared/sourceeditor/codemirror/lib/codemirror.css" line: 241}]
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - Buffered messages finished
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property --title-10-font-weight is not referenced -
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - Stack trace:
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - chrome://mochikit/content/browser-test.js:test_ok:1576
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:507
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
[task 2019-08-21T11:59:15.851Z] 11:59:15 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-08-21T11:59:15.852Z] 11:59:15 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-08-21T11:59:15.852Z] 11:59:15 INFO - Ignored error "Unknown property ‘appearance’. Declaration dropped." on resource://devtools/client/debugger/src/components/shared/Button/styles/CommandBarButton.css because of whitelist item {"sourceName":"/devtools\/client\/debugger\/src\/components\/([A-z\/]+).css/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.852Z] 11:59:15 INFO - Ignored error "Unknown property ‘-moz-border-radius’. Declaration dropped." on chrome://devtools/content/shared/sourceeditor/codemirror/lib/codemirror.css because of whitelist item {"sourceName":"/codemirror\.css$/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.852Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.852Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.853Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.853Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.853Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.855Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.855Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.856Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.856Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.856Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.859Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.859Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.859Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.859Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.865Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.865Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}
[task 2019-08-21T11:59:15.866Z] 11:59:15 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true}

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6d5191abbb8
Create sub component for manifestItem (part 2), r=ladybenko,fluent-reviewers,flod

Comment 9

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

removed ununsed css var

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e6d5191abbb8

Comment 11

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Attachment: Bug 1566011 - Fix duplicated locales, r=flod!,ladybenko!

fixed duplicated locales caused by rebase

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faa8347d3c18
Fix duplicated locales, r=flod,ladybenko,fluent-reviewers

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset faa8347d3c18 (Bug 1566011) for devtools failures

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=faa8347d3c1886af5ba3b5246915f04bb1de3066

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262872798&repo=autoland&lineNumber=355

Backout: https://hg.mozilla.org/integration/autoland/rev/aff1dabd253a2e12c48badc32f36b5e7d6691771

Comment 14

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Updated jest snapshot.
Try passed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f31dc4a1a3ab74f2867897046a2c7c843ca2bb9

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/090226588d6c
Fix duplicated locales, r=flod,ladybenko,fluent-reviewers

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/090226588d6c