1575499 - Manifest view part 2: add tests, remove duplication, fix UI issues, etc.

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P1)

Description

[Belén [:ladybenko]]

We need to address some of the issues that were pointed out in the review of previous patch https://phabricator.services.mozilla.com/D41909. The most important tasks that should be addressed in this bug are:

• Remove code duplication
• Improve "blank" state
• Add components tests for different props configuration

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1575499 - Part 1: Rename ManifestView to Manifest

Comment 2

[Belén [:ladybenko]]

Attachment: Bug 1575499 - Part 2: Avoid duplicated code

Comment 3

[Belén [:ladybenko]]

Attachment: Bug 1575499 - Part 3: UI fixes and CSS refactor

Comment 4

[Belén [:ladybenko]]

Attachment: Bug 1575499 - Part 4: Add Jest tests

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0508f95b5ac
Part 1: Rename ManifestView to Manifest r=Ola
https://hg.mozilla.org/integration/autoland/rev/1202ceb56028
Part 2: Avoid duplicated code r=Ola
https://hg.mozilla.org/integration/autoland/rev/63c3e7548bc0
Part 3: UI fixes and CSS refactor r=Ola
https://hg.mozilla.org/integration/autoland/rev/a5d956f10856
Part 4: Add Jest tests r=Ola

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e0508f95b5ac
https://hg.mozilla.org/mozilla-central/rev/1202ceb56028
https://hg.mozilla.org/mozilla-central/rev/63c3e7548bc0
https://hg.mozilla.org/mozilla-central/rev/a5d956f10856