Closed Bug 1575499 Opened 2 months ago Closed 2 months ago

Manifest view part 2: add tests, remove duplication, fix UI issues, etc.

Categories

(DevTools :: Application Panel, enhancement, P1)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: ladybenko, Assigned: ladybenko)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

We need to address some of the issues that were pointed out in the review of previous patch https://phabricator.services.mozilla.com/D41909. The most important tasks that should be addressed in this bug are:

  • Remove code duplication
  • Improve "blank" state
  • Add components tests for different props configuration
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Manifest view part 2: add support for errors, remove duplication, etc. → Manifest view part 2: add tests, remove duplication, fix UI issues, etc.
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0508f95b5ac
Part 1: Rename ManifestView to Manifest r=Ola
https://hg.mozilla.org/integration/autoland/rev/1202ceb56028
Part 2: Avoid duplicated code r=Ola
https://hg.mozilla.org/integration/autoland/rev/63c3e7548bc0
Part 3: UI fixes and CSS refactor r=Ola
https://hg.mozilla.org/integration/autoland/rev/a5d956f10856
Part 4: Add Jest tests r=Ola
You need to log in before you can comment on or make changes to this bug.