1566115 - about:logins is slow while filtering

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P1)

Description

[klint]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

I opened about:logins in FF69 beta 4
I entered a search criteria in the search field

Actual results:

the letters I typed appeared very very slowly in the search field, making the whole search feature unusable.
That was not the case the last time I tested in FF68.

Also, navigating in the list of entries in quite slow.

Comment 1

[klint]

Forgot to mention that I have 1200 saved passwords.

Comment 2

[Matthew N. [:MattN]]

Jared, can you triage?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://searchfox.org/mozilla-central/rev/22b330ecb3edba1536a54887060cbdd09db21c59/browser/components/aboutlogins/content/components/login-list.js#59,164-165 highlights the problem.

Each time the filter is updated we clear out the list of logins and re-render them. This profile, https://perfht.ml/2YXaTWB, shows the majority of work is from render(). includes() shows up there which is called from _applyFilter but this is only 13% compared to 53% of the time in LoginListItem.create.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1566115 - Only add/remove login-list-items when they are removed from the internal list, and update the remaining ones instead of clearing the whole list and rebuilding it on each render. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1566115 - Apply the sort of login list items by just rearranging the DOM nodes as needed. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1566115 - Store references to the logins in a map keyed on their GUID and a separate sorted array of GUIDs. r?Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ec458006e91
Store references to the logins in a map keyed on their GUID and a separate sorted array of GUIDs. r=MattN
https://hg.mozilla.org/integration/autoland/rev/4782eb7f3b44
Only add/remove login-list-items when they are removed from the internal list, and update the remaining ones instead of clearing the whole list and rebuilding it on each render. r=MattN
https://hg.mozilla.org/integration/autoland/rev/826dc645c09c
Apply the sort of login list items by just rearranging the DOM nodes as needed. r=Gijs,MattN

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1ec458006e91
https://hg.mozilla.org/mozilla-central/rev/4782eb7f3b44
https://hg.mozilla.org/mozilla-central/rev/826dc645c09c