1566200 - Various search engines are using the wrong encoding for search parameters after switch to WebExtensions

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Alice0775 White]

+++ This bug was initially created as a clone of Bug #1565779 +++

Reproducible : always

Steps to Reproduce:

1. Set default search engine to ヤフオク！ or 楽天市場
2. Select Japanese text in email e.g,"パソコン"
3. Right click ヤフオク！で検索 or 楽天市場で検索

Actual results:
Unable search in Japanese text due to Mojibake in Default Browser

Expected Results:
Search should successfully perform in Default Browser

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=1ce8576d29ec4e7ec92faec84b082ff59e18f0a8&tochange=ddfc8b3514165e69dbf83fdb4b7928555268f49a
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b5bcfc2617667e3fc7a095b262b80377b2542446&tochange=a17f163841e956c10eb74cdbe27d7073facf6b7f

Regressed by: Bug 1544013 and Bug 1496075

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks. No problem porting the patch from bug 1565779.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: search-engines-non-utf-8.patch

Same patch as in bug 1565779.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2fb0ea027df
Port bug 1565779: Add encoding to non-UTF-8 engines. r=me

Comment 4

[Jorg K (CEST = GMT+2)]

TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/4feb1d61cf850d3b4e1cd5685ed5a66c62dfb6a1

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/192982b565aaad4b96429a0d95a6c335cc19d982

Comment 5

[Jorg K (CEST = GMT+2)]

Looks like the patch from bug 1565779 didn't work :-(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba54e80a5691
Follow-up: Move encoding definitions to the correct location in the search engine manifest files. r=me DONTBUILD

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta 5 or 6 or ESR:
https://hg.mozilla.org/releases/comm-beta/rev/f490f9e67f6599d7a5c9fc1d1d070c5166992e8d

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/8f5dba7221f0c6cd9e36302ad4a33aab0d86cb12