Closed Bug 1566308 Opened 5 years ago Closed 1 month ago

Findbar text unreadable when using built-in light theme with dark GTK theme

Categories

(Toolkit :: Themes, defect, P2)

61 Branch
Unspecified
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1634449
Tracking Status
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- fix-optional
firefox70 --- fix-optional

People

(Reporter: argonvegell, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Attached image 2019-07-16-094220_1366x768_scrot.png (obsolete) —

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

create a test profile on "about:profiles" and enabled Light Theme on said profile, go to Firefox Home Page, then press Ctrl+F and type "facebook".

Actual results:

"facebook" text on Find bar is not visible.

Expected results:

"facebook" text on Find bar should be black.

I forgot to mention, my operating system is Lubuntu 18.04.

Attachment #9078317 - Attachment is obsolete: true

Looks like you are using a custom system theme, the default lubuntu 18.04 theme does not have this issue. What theme changes have you made?

BTW, I have found another Light Theme that seems to work well with my setup: https://addons.mozilla.org/en-US/firefox/addon/minimal-light-theme-webext/
This theme is similar to Firefox's built-in Light theme, but without the issue present in this bug report.

Minimal Light Theme WebExt

STR:

  1. Enable a dark system theme (eg Yaru-dark, Adwaita-dark) on Ubuntu 19.04.
  2. In Firefox, enable the built-in light theme.
  3. Press Ctrl+F to show findbar and search for a word that exists on the page.

The findbar text is white on white background and can only be read by highlighting it.

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Theme
Ever confirmed: true
Keywords: regression
OS: Unspecified → Linux
Regressed by: 1418605
Summary: Firefox Light Theme Finder Bar Issue Text Not Visible → Findbar text unreadable when using built-in light theme with dark GTK theme
Version: 68 Branch → 61 Branch

So the problem here is that the urlbar and the searchbar use hsla(0,0%,100%,.8) and black as fallback respectively for toolbar background-color and color, while the findbar and usercontext.css both use -moz-Field and -moz-FieldText.

-moz-Field and -moz-FieldText are sensitive to the system theme, while the first ones are not. Not sure how to fix this correctly here, should we just use hsla(0,0%,100%,.8) and black as fallback everywhere ?

Component: Theme → Themes
Flags: needinfo?(dao+bmo)
Product: Firefox → Toolkit
Priority: -- → P2

(In reply to Tim Nguyen :ntim from comment #8)

So the problem here is that the urlbar and the searchbar use hsla(0,0%,100%,.8) and black as fallback respectively for toolbar background-color and color, while the findbar and usercontext.css both use -moz-Field and -moz-FieldText.

-moz-Field and -moz-FieldText are sensitive to the system theme, while the first ones are not. Not sure how to fix this correctly here, should we just use hsla(0,0%,100%,.8) and black as fallback everywhere ?

Seems like we should set both toolbar_field and toolbar_field_text in the light theme? And the webextension theme framework should probably reject either property if the other one isn't set? I don't think there's a way to sanely fix this for all themes just with the fallback.

Flags: needinfo?(dao+bmo)

(In reply to Dão Gottwald [::dao] from comment #9)

I don't think there's a way to sanely fix this for all themes just with the fallback.

I agree with your two other suggestions, but I think we should fix having 2 different fallbacks for the urlbar/searchbar and the findbar, I don't think that helps in terms of sanity either. Should the findbar just use hsla(0,0%,100%,.8) and black as fallback ?

Flags: needinfo?(dao+bmo)
Severity: normal → S3

This should work now.

Status: NEW → RESOLVED
Closed: 1 month ago
Flags: needinfo?(dao+bmo)
Resolution: --- → WORKSFORME

Fixed by Bug 1634449.

Duplicate of bug: 1634449
Resolution: WORKSFORME → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: