1634449 - White text on white background in the Find text box

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Pedro Côrte-Real]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

I run firefox in Ubuntu with the following theme settings:

• System GTK is set to Adwaita-dark
• Firefox theme is set to Light

Actual results:

I bring up the search box in any page with Ctrl-F and type. White text on white background is the result

Expected results:

I should be getting white text on white background. It works properly if I do any of the following:

• Set the system theme to the normal light Adwaita
• Set the firefox theme to the default or dark themes
• Set the system to light Adwaita and Firefox to the dark theme (the exact opposite)

For some reason only this combination causes a problem.

Comment 1

[Pedro Côrte-Real]

Having searched better this seems like a duplicate of this:

https://bugzilla.mozilla.org/show_bug.cgi?id=1411425

I commented on that bug but am still seeing it even long after the fix was supposed to be done. So maybe what I'm seeing is a different issue?

Comment 2

[Pedro Côrte-Real]

Sorry, I mean this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=70315

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Let me poke real quick, I don't think it's necessarily a dupe...

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Sorry for the lag. This is a bug in the light theme, it's setting a background but not the foreground color, so the result if you use a dark system theme is white on white.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1634449 - Set toolbar_field_text in the light theme. r=Gijs,dao

We're setting the background but not the text color on the light theme,
which means that per these two rules:

https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/toolkit/themes/shared/findBar.inc.css#63-64

You'll get:

background-color: #fff;
color: -moz-Field;

If you have a dark system theme (like Adwaita Dark on Linux) where
-moz-Field is dark, then badness happens and you get white-on-white.

The color is just tab_background_text, which seems to work quite nicely
and is the same that the dark theme does for this field.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26952e3b6113
Set toolbar_field_text in the light theme. r=dao

Comment 8

[Pedro Côrte-Real]

Thanks!

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/26952e3b6113

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build as well as Beta 77.0b2.

Comment 11

[Pedro Côrte-Real]

Just installed Firefox 77.0.1 and this is indeed fixed. Thanks!

Comment 12

[Pedro Côrte-Real]

This has regressed for me, either because of Firefox 79 or the new user session I was forced to create in the upgrade to 79. I am once again seeing white text on white background in the Find box when using a dark system theme and the light Firefox theme.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Can you file a bug? I can't reproduce it on Nightly though.

Comment 14

[Pedro Côrte-Real]

The bug is exactly this one. Should a new one be filed?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Yes, generally reopening closed bugs is not great, specially if they were closed long ago.