Closed Bug 1566353 Opened 5 months ago Closed 3 months ago

Add 'geckoview_streaming' to Gecko metrics that should go to Fenix

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

RESOLVED DUPLICATE of bug 1568589
Tracking Status
firefox70 --- affected

People

(Reporter: Dexter, Unassigned)

References

(Blocks 1 open bug)

Details

We have a list of Gecko metrics that should be reported by Fenix in order to track product performance and general health.

We need to add geckoview_streaming to the list of products in the products key of the respective metric definition in the histogram.json file.

Blocks: 1566340
Depends on: 1566352
Blocks: 1566354
Priority: -- → P3

Hey Chris,

this is related to bug 1568589: when adding a new metric in metrics.yaml, we should also tag the related histogram accordingly in Histograms.json. This should probably be done by the same person asking for data-review. Do you know who should do that?

Flags: needinfo?(cpeterson)

I'm the wrong Chris, but I'm here anyway so here's a Data Steward's drive-by:

Ideally the person requesting Data Review is the same person responsible for the probes. They need to be able to answer questions about the collections to fill in the review request form, and if the probes are permanent they either need to be or need to know who is going to be responsible for monitoring the probes over their lifetimes.

From the spreadsheet, that'd be :kats and :bdekoz?

As a process note, since both metrics.yaml and Histograms.json live in the same repo, I recommend performing the changes to both files in the same bug. That will make it easier to annotate the metrics with relevant bugs and help people find the Data Reviews.

reply to needinfo(In reply to Alessio Placitelli [:Dexter] - PTO until 26/July from comment #1)

this is related to bug 1568589: when adding a new metric in metrics.yaml, we should also tag the related histogram accordingly in Histograms.json. This should probably be done by the same person asking for data-review. Do you know who should do that?

I agree with chutten. Same for bug 1568589. Kats is on paternity leave, so I needinfo'd his manager Jessie in that bug.

Do we need lint checks or assertions to make sure new metrics in metrics.yaml are tagged correctly in Histograms.json?

Flags: needinfo?(cpeterson) → needinfo?(alessio.placitelli)

(In reply to Chris Peterson [:cpeterson] from comment #3)

Do we need lint checks or assertions to make sure new metrics in metrics.yaml are tagged correctly in Histograms.json?

We have bug 1566355 for this, but it's somehow tricky, so we don't plan on implementing that in the short term. For the short term, someone from the Glean team should be reviewing changes to the metircs.yaml file.

Flags: needinfo?(alessio.placitelli)

Closing this in favour of bug 1568589, as both histogram.json and metric.yaml need to be modified, at the same time.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1568589
You need to log in before you can comment on or make changes to this bug.