Closed Bug 1566354 Opened 5 months ago Closed 5 months ago

Create an initial 'metrics.yaml' file for Gecko telemetry

Categories

(Data Platform and Tools :: Glean: SDK, task, P1)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Dexter, Assigned: Dexter)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [telemetry:glean-rs:m7])

Attachments

(1 file)

This bug is for introducing a metrics.yaml file in mozilla-central, which would hold the Glean SDK metric definition for the metrics marked as 'geckoview_streaming' in the histogram.json file.

The file should probably live in toolkit/components/telemetry/geckoview/streaming along with the GeckoView streaming telemetry implementation.

Blocks: 1566340
Depends on: 1566353
Priority: -- → P3
Whiteboard: [telemetry:glean-rs:m?]
Blocks: 1566355
Depends on: 1566356
Blocks: 1566373

We'd like to suggest the metrics.yaml to live in the toolkit/components/telemetry module, in the toolkit/components/telemetry/geckoview/streaming path. That's the same module where the Histograms.json file lives. I have no strong opinion about this, but I was considering these factors:

  • the Telemetry module build system will need to check, at build time, both the Histogram.json and the metrics.yaml;
  • Gecko can be built without the Telemetry module and metrics.yaml doesn't make sense without its only consumer (the toolkit:telemetry module);

I saw you suggested for it to live in mozilla-central/mobile/android/geckoview/metrics.yaml: would you be ok with it living in the telemetry module for the above reasons?

I don't feel strongly about this, but it might be less surprising for engineers.

Flags: needinfo?(nalexander)

(In reply to Alessio Placitelli [:Dexter] from comment #1)

We'd like to suggest the metrics.yaml to live in the toolkit/components/telemetry module, in the toolkit/components/telemetry/geckoview/streaming path. That's the same module where the Histograms.json file lives. I have no strong opinion about this, but I was considering these factors:

  • the Telemetry module build system will need to check, at build time, both the Histogram.json and the metrics.yaml;
  • Gecko can be built without the Telemetry module and metrics.yaml doesn't make sense without its only consumer (the toolkit:telemetry module);

I saw you suggested for it to live in mozilla-central/mobile/android/geckoview/metrics.yaml: would you be ok with it living in the telemetry module for the above reasons?

I would be fine with this (and saw it in the proposal, and was fine with it). We already have mobile/android/base reach out to toolkit/crash_reporter (see https://searchfox.org/mozilla-central/rev/da855d65d1fbdd714190cab2c46130f7422f3699/mobile/android/base/moz.build#135-138).

I don't feel strongly about this, but it might be less surprising for engineers.

I also don't feel strongly about this, and trust you to know what folks working in toolkit/components/telemetry will find natural.

Flags: needinfo?(nalexander)
Assignee: nobody → alessio.placitelli
Priority: P3 → P1
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:m7]

This registry file will be used for the new streaming
telemetry API used by GeckoView.

Pushed by aplacitelli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18a7636fb0d1
Add an empty metrics.yaml file for streaming telemetry r=janerik
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Blocks: 1589390
You need to log in before you can comment on or make changes to this bug.