1566392 - Review expired histograms for toolbox performance monitoring

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

We have several expired telemetry histograms measuring toolbox performance. We should either remove them entirely or update their expiry.

Histograms:

• DEVTOOLS_COLD_TOOLBOX_OPEN_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_WARM_TOOLBOX_OPEN_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_TOOLBOX_PAGE_RELOAD_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_INSPECTOR_NEW_ROOT_TO_RELOAD_DELAY_MS (expired in 62) (searchfox)

Comment 1

[Julian Descottes [:jdescottes]]

Hi Alex,

Harald's suggestion for the probes here is to extend all of them except TOOLBOX_PAGE_RELOAD.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1566383#c2

I'm happy to provide the patch to either extend or remove the probes but I'd like your opinion as well.

Comment 2

[Alexandre Poirot [:ochameau]]

TBH I never had meaningful proof that this telemetry data was relevant, so I'm fine removing them.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the answer let's remove them then!

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1566392 - Review expired devtools performance histograms

Comment 5

[:Harald Kirschner :digitarald]

We discussed off-channel to extend those probes and decided to extend the probes until 80 and then revisit on how useful they are or what the alternative would be.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1566392 - Extend DevTools toolbox performance histograms

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: bug_1566392_data_review.txt

Comment 8

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9081928 [details]
bug_1566392_data_review.txt

> We don't have any other way to get this data.

I realize you're interested in in-the-wild measurements, but lab testing should hopefully tell you something useful about how Fission is impacting perf.

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Because it reveals toolbox open events, Category 2, interaction data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers**?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

Yes, Julian and Harald are responsible for deciding whether to renew after Firefox 80.

9) Does the data collection use a third-party collection tool?

No.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e435f0ad9d83
Extend DevTools toolbox performance histograms r=janerik

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e435f0ad9d83