1566383 - [meta] Review expired DevTools probes (scalars, histograms and events)

Status: NEW

(DevTools :: General, task)

Description

[Julian Descottes [:jdescottes]]

We have several expired telemetry probes. We should either remove them entirely or update their expiry.

Histograms:

• DEVTOOLS_COLD_TOOLBOX_OPEN_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_WARM_TOOLBOX_OPEN_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_TOOLBOX_PAGE_RELOAD_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_INSPECTOR_NEW_ROOT_TO_RELOAD_DELAY_MS (expired in 62) (searchfox)
• DEVTOOLS_DEBUGGER_LOAD_SOURCE_MS (expired in 66) (searchfox)
• DEVTOOLS_APPLICATION_TIME_ACTIVE_SECONDS (expired in 66) (searchfox)
• DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_FILTER_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_DIFF_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_INVERTED_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT (expired in 56) (searchfox)

Scalars:

• devtools.copy.unique.css.selector opened (expired in 59) (searchfox)
• devtools.copy.full.css.selector opened (expired in 59) (searchfox)
• devtools.copy.xpath opened (expired in 59) (searchfox)
• devtools.inspector three_pane_enabled (expired in 65) (searchfox)
• devtools.shadowdom shadow_root_displayed (expired in 66) (searchfox)
• devtools.shadowdom shadow_root_expanded (expired in 66) (searchfox)
• devtools.shadowdom reveal_link_clicked (expired in 66) (searchfox)
• devtools.application opened_count (expired in 66) (searchfox)
• devtools.toolbox tabs_reordered (expired in 65) (searchfox)
• devtools.changesview copy (expired in 69) (searchfox)
• devtools.changesview contextmenu (expired in 69) (searchfox)
• devtools.changesview contextmenu_copy (expired in 69) (searchfox)

Comment 1

[Julian Descottes [:jdescottes]]

Hi Harald!

Do you have any input to share on which probes should be kept/removed (or migrated to events?)

Comment 2

[:Harald Kirschner :digitarald]

Thanks a lot for compiling the list, Julian!

Here my take on tagging the probes for extend/remove. I wasn't sure about niche Inspector features, but mbalfanz probably has an idea.

Histograms:

DEVTOOLS_COLD_TOOLBOX_OPEN_DELAY_MS: Extend
DEVTOOLS_WARM_TOOLBOX_OPEN_DELAY_MS: Extend
DEVTOOLS_TOOLBOX_PAGE_RELOAD_DELAY_MS: Remove
DEVTOOLS_INSPECTOR_NEW_ROOT_TO_RELOAD_DELAY_MS: Extend
DEVTOOLS_DEBUGGER_LOAD_SOURCE_MS: Extend
DEVTOOLS_APPLICATION_TIME_ACTIVE_SECONDS: Extend
DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT: Remove
DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT: Remove
DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT: Remove
DEVTOOLS_MEMORY_FILTER_CENSUS: Remove
DEVTOOLS_MEMORY_DIFF_CENSUS: Remove
DEVTOOLS_MEMORY_INVERTED_CENSUS: Remove
DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT: Remove
DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT: Remove
DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT: Remove

Scalars:

devtools.copy.unique.css.selector.opened: ?
devtools.copy.full.css.selector.opened: ?
devtools.copy.xpath.opened: ?
devtools.inspector.three_pane_enabled: ?
devtools.shadowdom.shadow_root_displayed: Extend
devtools.shadowdom.shadow_root_expanded: Extend
devtools.shadowdom.reveal_link_clicked: Extend
devtools.application.opened_count: Extend
devtools.toolbox.tabs_reordered: Extend
devtools.changesview.copy: Extend
devtools.changesview.contextmenu: Extend
devtools.changesview.contextmenu_copy: Extend

Comment 3

[Martin Balfanz [:mbalfanz]]

The three expiring probes for the changes view devtools.changesview.* can be removed.

devtools.inspector.three_pane_enabled should ideally be extended as we will introduce some changes soon.

devtools.copy.unique.css.selector.opened, devtools.copy.full.css.selector.opened and devtools.copy.xpath.opened I'd like to extend as well, though I'm not listed as responsible for them :D

Comment 4

[Julian Descottes [:jdescottes]]

Thanks Martin!

(In reply to Martin Balfanz [:mbalfanz] from comment #3)

devtools.copy.unique.css.selector.opened, devtools.copy.full.css.selector.opened and devtools.copy.xpath.opened I'd like to extend as well, though I'm not listed as responsible for them :D

They don't seem to have any owner at the moment.
I can add you as owner at the same time as we request to extend them?