Closed
Bug 1566469
Opened 6 years ago
Closed 6 years ago
Use 'ms' instead of 'millis' for variables
Categories
(DevTools :: Netmonitor, task, P3)
DevTools
Netmonitor
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: Honza, Assigned: arunmohandm)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
This is a follow up for bug 1555634
We should be using ms instead of millis for variables dealing with milliseconds. It makes the code base more readable.
See also this comment:
https://phabricator.services.mozilla.com/D38051?vs=on&id=131929#1139299
Honza
|
Reporter | |
Updated•6 years ago
|
Keywords: good-first-bug
Priority: -- → P3
|
|
Reporter | |
Updated•6 years ago
|
Component: Debugger → Netmonitor
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
I looked up millis\b and replaced all those occurences with ms (Ms feels weird). Is that fine?
What do you think?
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9081146 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #9081146 -
Attachment is obsolete: false
|
|
||
Updated•6 years ago
|
Attachment #9081146 -
Attachment is obsolete: true
|
||
Updated•6 years ago
|
Assignee: nobody → arunmohandm
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee032bb4df37
Rename millis to ms. r=nchevobbe
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•