Closed Bug 1566469 Opened 4 months ago Closed 3 months ago

Use 'ms' instead of 'millis' for variables

Categories

(DevTools :: Netmonitor, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Honza, Assigned: arunmohandm)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

This is a follow up for bug 1555634

We should be using ms instead of millis for variables dealing with milliseconds. It makes the code base more readable.

See also this comment:
https://phabricator.services.mozilla.com/D38051?vs=on&id=131929#1139299

Honza

Keywords: good-first-bug
Priority: -- → P3
Component: Debugger → Netmonitor

I looked up millis\b and replaced all those occurences with ms (Ms feels weird). Is that fine?

What do you think?

Flags: needinfo?(nchevobbe)
Attachment #9081146 - Attachment is obsolete: true
Attachment #9081146 - Attachment is obsolete: false
Attachment #9081146 - Attachment is obsolete: true

clearing needinfo

Flags: needinfo?(nchevobbe)
Assignee: nobody → arunmohandm
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.