1566673 - When an open menulist in a popup panel has focus, pressing tab closes both menulist and panel

Status: RESOLVED DUPLICATE of bug 1811487

(Toolkit :: UI Widgets, defect, P3)

Description

[James Teh [:Jamie]]

Spun off bug 1561517 comment 7.

STR:

1. Open the Browser Toolbox.
2. Run this code:

   p = document.createXULElement("panel");
   document.getElementById("nav-bar").append(p);
   ml = document.createXULElement("menulist");
   p.append(ml);
   mp = document.createXULElement("menupopup");
   ml.append(mp);
   mp.append(document.createXULElement("menuitem"));
   p.append(document.createXULElement("button"));
   setTimeout(() => p.openPopup(), 3000);
   

3. Switch back to the main Firefox window within 3 seconds.
4. Wait for the popup to open.
5. Press tab to focus the menulist.
6. Press alt+downArrow to expand it.
7. Press tab.
   • Expected: The menulist should be closed, but the panel (p) should remain open.
   • Actual: Both the menulist and the panel are dismissed.

From bug 1561517 comment 9:

We should ideally be running the block at https://searchfox.org/mozilla-central/source/layout/xul/nsXULPopupManager.cpp#223 to limit closing to similar-type popups only, but the passed in aLastRolledUp argument is null. Likely, passing a dummy non-null pointer for the tab key (but not F10) at https://searchfox.org/mozilla-central/source/layout/xul/nsXULPopupManager.cpp#2199 would fix this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:aswan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Andrew Swan [:aswan]]

Neil, looks like this was spawned from a comment you made, can you prioritize this?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Bug 1811487 fixes this (initially by accident, but now I see it I just kept that minor behavior change).