1811487 - Cleanup rollup / hide popup APIs

Status: RESOLVED FIXED

(Core :: Widget, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1811487 - Clean-up some popup opening/closing code. r=stransky,tnikkel,mstange

No behavior change, but while I was going through this code I cleaned it
up a bit.

Depends on D167379

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1811487 - Clean-up popup hide / rollup APIs. r=cmartin

I'm about to extend them for bug 1811486, where I want to force in some
cases the rolled up popups to hide synchronously. These APIs use a ton
of boolean arguments that make them error prone, so refactor them a bit
to use strongly typed enums and flags.

Depends on D167380

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6350911c1c8d
Clean-up some popup opening/closing code. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/88c5316c2183
Clean-up popup hide / rollup APIs. r=cmartin

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_PanelMultiView_keyboard.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c1b9062baf16a6a833a5214e218cdf657dbdbcde

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=88c5316c218316c599a3dc6c6f7c8182fc1504a3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=403229811&repo=autoland&lineNumber=4303

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04bf167805d7
Clean-up some popup opening/closing code. r=tnikkel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9a25f51a254
Clean-up popup hide / rollup APIs. r=cmartin

Comment 8

[Iulian Moraru]

Backed out for causing bc failures related to PanelMultiView.

Push with failures

Failure log
Failure log for TV job

Backout link

[task 2023-01-23T18:07:02.479Z] 18:07:02     INFO - TEST-PASS | browser/components/customizableui/test/browser_1484275_PanelMultiView_toggle_with_other_popup.js | The panel is closed to begin with. - "closed" == "closed" - 
[task 2023-01-23T18:07:02.480Z] 18:07:02     INFO - Buffered messages finished
[task 2023-01-23T18:07:02.480Z] 18:07:02     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_1484275_PanelMultiView_toggle_with_other_popup.js | Test timed out - 
[task 2023-01-23T18:07:02.480Z] 18:07:02     INFO - GECKO(1472) | [Parent 1472, Main Thread] WARNING: NS_ENSURE_TRUE(mNameHashtable.Get(aName, &index)) failed: file /builds/worker/checkouts/gecko/storage/mozStorageRow.cpp:91
[task 2023-01-23T18:07:02.480Z] 18:07:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-23T18:07:02.481Z] 18:07:02     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_1484275_PanelMultiView_toggle_with_other_popup.js | Uncaught exception received from previously timed out test - ViewShown listener on #appMenu-protonMainView not removed before the end of test
[task 2023-01-23T18:07:02.858Z] 18:07:02     INFO - GECKO(1472) | MEMORY STAT | vsize 8038MB | residentFast 418MB | heapAllocated 143MB
[task 2023-01-23T18:07:02.858Z] 18:07:02     INFO - TEST-OK | browser/components/customizableui/test/browser_1484275_PanelMultiView_toggle_with_other_popup.js | took 90620ms
[task 2023-01-23T18:07:02.867Z] 18:07:02     INFO - GECKO(1472) | [Child 1479: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 11e54a000 == 2 [pid = 1479] [id = 6]
[task 2023-01-23T18:07:02.867Z] 18:07:02     INFO - GECKO(1472) | [Child 1479: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (106c1a5e0) [pid = 1479] [serial = 14] [outer = 0]
[task 2023-01-23T18:07:02.868Z] 18:07:02     INFO - GECKO(1472) | [Child 1479: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (11e54a800) [pid = 1479] [serial = 15] [outer = 106c1a5e0]
[task 2023-01-23T18:07:02.890Z] 18:07:02     INFO - checking window state
[task 2023-01-23T18:07:02.930Z] 18:07:02     INFO - TEST-START | browser/components/customizableui/test/browser_1701883_restore_defaults_pocket_pref.js

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/04bf167805d7

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb6f29e7d9c7
Clean-up popup hide / rollup APIs. r=cmartin,stransky

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bb6f29e7d9c7