Closed Bug 1566806 Opened 3 months ago Closed 3 months ago

[fission] Crash in [@ mozilla::ipc::IPDLParamTraits<T>::Write]

Categories

(Core :: DOM: Content Processes, defect, P2, critical)

70 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla70
Fission Milestone M4
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: calixte, Assigned: Nika, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-137d7fe5-8928-4de8-ab9f-296530190716.

Top 10 frames of crashing thread:

0 xul.dll static void mozilla::ipc::IPDLParamTraits<mozilla::dom::BrowsingContext*>::Write docshell/base/BrowsingContext.cpp:970
1 xul.dll mozilla::dom::PContentChild::SendWindowPostMessage ipc/ipdl/PContentChild.cpp:6621
2 xul.dll mozilla::dom::ContentParent::RecvWindowPostMessage dom/ipc/ContentParent.cpp:6018
3 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:10924
4 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2082
5 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1970
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
7 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
8 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308

There are 78 crashes (from 34 installations) in nightly 70 starting with buildid 20190716112534. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1563604.

[1] https://hg.mozilla.org/mozilla-central/rev?node=54d9810b02ae

Flags: needinfo?(nika)
Flags: needinfo?(singh.manish.21)

Repro on my computer with Fission enabled: load https://andygrove.io/2019/07/announcing-ballista/ and click the play button on the asciinema embed.

That patch didn't really regress this, it just added more assertions to prevent code which would racily cause another crash. I believe the attached bug will fix the general issue here.

Assignee: nobody → nika
Fission Milestone: --- → M4
Flags: needinfo?(nika)
Priority: -- → P2
No longer regressed by: 1563604
Summary: Crash in [@ mozilla::ipc::IPDLParamTraits<T>::Write] → [fission] Crash in [@ mozilla::ipc::IPDLParamTraits<T>::Write]

This is the top crash on Linux for the July 17 Nightlies.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8123bbb016f3
Check discarded status before forwarding WindowProxy messages between processes, r=farre
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
See Also: → 1579437
You need to log in before you can comment on or make changes to this bug.