1566806 - [fission] Crash in [@ mozilla::ipc::IPDLParamTraits<T>::Write]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-137d7fe5-8928-4de8-ab9f-296530190716.

Top 10 frames of crashing thread:

0 xul.dll static void mozilla::ipc::IPDLParamTraits<mozilla::dom::BrowsingContext*>::Write docshell/base/BrowsingContext.cpp:970
1 xul.dll mozilla::dom::PContentChild::SendWindowPostMessage ipc/ipdl/PContentChild.cpp:6621
2 xul.dll mozilla::dom::ContentParent::RecvWindowPostMessage dom/ipc/ContentParent.cpp:6018
3 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:10924
4 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2082
5 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1970
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
7 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
8 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308

There are 78 crashes (from 34 installations) in nightly 70 starting with buildid 20190716112534. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1563604.

[1] https://hg.mozilla.org/mozilla-central/rev?node=54d9810b02ae

Comment 1

[Laurențiu Nicola]

Repro on my computer with Fission enabled: load https://andygrove.io/2019/07/announcing-ballista/ and click the play button on the asciinema embed.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1566806 - Check discarded status before forwarding WindowProxy messages between processes,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

That patch didn't really regress this, it just added more assertions to prevent code which would racily cause another crash. I believe the attached bug will fix the general issue here.

Comment 4

[Andrew McCreight [:mccr8]]

This is the top crash on Linux for the July 17 Nightlies.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8123bbb016f3
Check discarded status before forwarding WindowProxy messages between processes, r=farre

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8123bbb016f3