1566930 - Default to yes on "Re-install geckoview AndroidTest?"

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Brendan Dahl [:bdahl]]

A lot of times I'm running something like ./mach build && ./mach test ... which can take a few minutes, and by the time I come back to the terminal it's stuck on the questions "Re-install geckoview AndroidTest?". It would be nice if that defaulted to "Yes", so I don't have to stick around and wait for the prompt.

Comment 1

[Brendan Dahl [:bdahl]]

Or even better would be if the build system new whether to install or not based on changes.

Comment 2

[Rob Wu [:robwu]]

I've implemented the --no-install flag to skip the checks and Re-install geckoview AndroidTest prompt at bug 1566984.

EDIT: agi pointed out that --no-install is exactly the opposite of what was requested here. This bug is asking for something like --install.

Comment 3

[Geoff Brown [:gbrown]]

The thinking behind the addition of the install prompting was that there are both cases where the mach user wants to install/re-install (just built but did not install/re-install) and cases where the mach user does not (have already installed, want to repeat runs quickly without app changes, have installed a downloaded build, etc).

Seeing all the "default to ..." bugs, I am open to removing the prompting and replacing it with a default (always install or always don't install) + a command line over-ride (--no-install or --install). But I think the prompting is useful, at least for the casual user of android mach commands, as a reminder of the (possible) need to install. I favor keeping the prompting and adding --no-install for all android commands; default to install can then be achieved with 'mach install && mach test --no-install'.

Comment 4

[Brendan Dahl [:bdahl]]

Attachment: Bug 1566930 - Default to auto install on the various android mach commands. r=gbrown

Comment 5

[Brendan Dahl [:bdahl]]

During the Berlin all hands this came up in the GeckoView room. The consensus was 99% of the time we want to install the app by default and having to either answer the prompt or use the mach install someApp && mach test ... are cumbersome.

Comment 6

[Greg Mierzwinski [:sparky]]

(Copied from the phab review).

:gbrown, I think that we could add an environment flag like MOZ_DISABLE_ADB_INSTALL and check for it either in the harnesses or in the device to determine if we should install or not.

With this, we'll be able to have the default install behaviour, and for those of us who never use it, we can permanently disable it with the flag. We could either add it here into adb.py or we could use it on a per-harness basis (I could make a follow-up patch for the per-harness one).

What do you think about this?

Comment 7

[Geoff Brown [:gbrown]]

Answered in phab review. Thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef6d3ace1b4a
Default to auto install on the various android mach commands. r=gbrown,perftest-reviewers,whimboo,sparky

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ef6d3ace1b4a