1617757 - `./mach run` for Android should support a flag to skip the install confirmation

Status: RESOLVED DUPLICATE of bug 1566930

(Firefox Build System :: Mach Core, enhancement)

Description

[Markus Stange [:mstange]]

./mach run for Android always asks if it should Re-install geckoview_example? (Y/n). After pressing enter it takes another minute until the installation is complete.

I'd like to have a way to say ahead of time "yes, please re-install". According to ./mach run --help there is a way to say "no" by using the --no-install flag, but I don't see a --yes-install flag.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1617757 - Use ./mach run --install={yes,no} instead of --no-install; r?gbrown

With only a --no-install flag, there is no way to force reinstalling a
binary to the Android device during './mach run'.

Now we can use --install=no or --install=yes to supply an answer to the
question, while the default of prompting the user remains if no
--install flag is given.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 9128955 [details]
Bug 1617757 - Use ./mach run --install={yes,no} instead of --no-install; r?gbrown

Does this patch work as intended for you?

Comment 3

[Geoff Brown [:gbrown]]

It's not as concise, but couldn't you use 'mach install && mach run --no-install' in this case?

Comment 4

[Markus Stange [:mstange]]

(In reply to Geoff Brown [:gbrown] from comment #3)

It's not as concise, but couldn't you use 'mach install && mach run --no-install' in this case?

I see! I guess it would work - I didn't know about mach install.

I don't have a strong opinion on the name of the command line arguments or the defaults. But I agree that it's very valuable to have arguments that are consistently supported across the mach run / mach test commands.

Comment 5

[Michael Shal [:mshal]]

There is also bug 1566930 - should this be duped to that?

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 7

[Mitchell Hentges [:mhentges] 🦀]

Looks like 1566930 is closed, which also solved this bug. Closing.