1566942 - Very slow animations with SVG filters.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Testcase

Test-case is reduced from https://codepen.io/JeremiePat/full/GVKxYa / https://twitter.com/JeremiePat/status/1151501718624047104, with a poor attempt and making the animations longer.

It spends a lot of time in the compositor, and during layer building. Probably we can try to do something better.

Here's a profile on a clean profile:

• Without WebRender: https://perfht.ml/2XXI4Ie

Will get a WR profile in a second.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

WR profile: https://perfht.ml/2XWfQxE

Though nothing stands out, the animation is still very janky.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

On Mac with WebRender https://perfht.ml/2Y8NlAZ the biggest problem looks like malloc contention. This is presumably because of https://hg.mozilla.org/mozilla-central/rev/d9efe6d06931

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Unlikely to get anything for 70

Comment 4

[Nicolas Silva [:nical]]

I am still seeing a lot of malloc contention on this test case, caused by many nested filters .

Comment 5

[Mayank Bansal]

This feels smooth to me on latest Nightly: https://share.firefox.dev/4dcQQJc

Comment 6

[Ashley Hale [:ahale]]

Confirmed this is fixed by enabling gfx.webrender.svg-filter-effects (Bug 1906212).