Closed Bug 1566952 Opened 1 year ago Closed 1 year ago

Annotate mochitests that crash with Fission enabled

Categories

(Testing :: Mochitest, task, P2)

task

Tracking

(Fission Milestone:M4, firefox70 fixed)

RESOLVED FIXED
mozilla70
Fission Milestone M4
Tracking Status
firefox70 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1566182 +++

Bug 1566182 intentionally didn't annotate tests that crash, based on discussions in our initial meeting. Apparently minds changed between then and now, though, so we're going to skip crashing tests for now in order to get tests running on all branches sooner.

Fission Milestone: --- → M4

The current comment processing code strips whitespace from a line, calculates
comment offsets based on the unstripped version, and then strips those offsets
from the stripped version. That means that, for multi-line directives, which
typically have two spaces at the front, the offsets are wrong and lines with
comments end up with a trailing "# " that the expression parser doesn't
understand.

This patch fixes the comment parser to correctly use the stripped line for
offset calculations instead.

When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.

This patch adds annotations to the new failures that show up after part 1.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f079bf147a34310c235346eefc5377ce884d5c1a
Bug 1566952: Part 0 - Fix comment processing in multi-line directives. r=ahal

https://hg.mozilla.org/integration/mozilla-inbound/rev/06668c34827202d073ceb812b51efe46b59a88b6
Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/226d9503e6cb22745465aeb1a688ed4436c5569e
Bug 1566952: Part 2 - Update Fission failure annotations after skipping crashes. r=mccr8
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
See Also: → 1584471
You need to log in before you can comment on or make changes to this bug.