1566968 - Stub installer profile refresh prompt button partially cut off

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Molly Howell (she/her) (no longer active)]

Bug 1562115 addressed an issue where the stub installer's install page text was overflowing the bottom of the window in certain locales. That issue was addressed, but in testing the fix it was discovered that a similar issue can occur on the reinstall profile refresh page (see bug 1562115 comment 15), resulting in the button there being partially cut off by the bottom of the window.

In my testing this only seems to occur when display scaling is set to 125% and not for other values.

Comment 1

[Molly Howell (she/her) (no longer active)]

I don't think that trying to figure out the vagaries of display scaling across multiple Windows versions and how dialog rendering is affected by them is going to be the right path to take here; probably better to just remove some of the spacing and call it a day. If other locales turn up with even larger translations, then we'll reexamine, but I don't see any of those right now.

Comment 2

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1566968 - Prevent very long reinstall prompt strings from overflowing the window. r=agashlin

Comment 3

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Test with max heading height

It might be helpful to test with the size of the label set to the max height set in INSTALL_HEADER_HEIGHT and PROFILE_CLEANUP_LABEL_HEIGHT and friends, since we are allowing the size to go up to that. Here's a patch I was using to try this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d574069441dc
Prevent very long reinstall prompt strings from overflowing the window. r=agashlin

Comment 5

[Molly Howell (she/her) (no longer active)]

Comment on attachment 9078894 [details]
Bug 1566968 - Prevent very long reinstall prompt strings from overflowing the window. r=agashlin

Beta/Release Uplift Approval Request

• User impact if declined: Stub installer cosmetic defect for the ru locale (possibly other locales, but none that I could see immediately).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): All this patch does is reduce a couple of padding amounts to make sure everything fits in the window.
• String changes made/needed:

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d574069441dc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Just to confirm, ESR68 isn't affected here?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078894 [details]
Bug 1566968 - Prevent very long reinstall prompt strings from overflowing the window. r=agashlin

Fixes a cosmetic issue in the stub installer. Approved for 69.0b7.

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec6c6890c684

Comment 10

[Molly Howell (she/her) (no longer active)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Just to confirm, ESR68 isn't affected here?

Correct, because this is a stub installer bug and we don't build ESR stub installers.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078894 [details]
Bug 1566968 - Prevent very long reinstall prompt strings from overflowing the window. r=agashlin

Not planning another Fx68 dot release at this time. I think this can just ride with 69.

Comment 12

[Oana Botisan, Desktop QA]

We verified the fix using Firefox 69.0b7 (DE and RU locales) on Windows 10 x64, Windows 7 x32 and Windows 8.1 x64. The bug is not reproducing anymore.

Comment 13

[Anca Soncutean, Desktop QA]

(In reply to Oana Botisan, Desktop Release QA from comment #12)

We verified the fix using Firefox 69.0b7 (DE and RU locales) on Windows 10 x64, Windows 7 x32 and Windows 8.1 x64. The bug is not reproducing anymore.

This issue is verified fixed on Fx 70.0b3 as well, with the mentioned above locales and platforms.