1566985 - [Protections Panel] "Site Not Working?" link should be hidden when TP toggle is OFF

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

The Site Not Working? link doesn't go away upon toggling TP. Additionally, it DOES go away if TP is toggled again. Seems to be a broken state machine.

Comment 1

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566985 - Part 1: Fixing the hidden state of 'Site not working' link. r?nhnt11!

This patch removes the old behavior of the breakage link which is
originally from the identity panel. The old behavior will cause the
hidden state to be incorrect, so removing them would fix the problem.

Also, this patch implements new behavior of the breakage link.

Comment 2

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566985 - Part 2: Remove unnecessary pref of the breakage report UI. r?nhnt11!

Since we will show "Site not working" link for all channels. So we don't
need those prefs anymore.

Depends on D38635

Comment 3

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566985 - Part 3: Fixing the height of the TP switch section when TP is disabled. r?nhnt11!

This patch fixes the problem that TP switch section has an incorrect
height when the TP is disabled for the site.

Depends on D38636

Comment 4

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1566985 - Part 4: Update tests and add a test for check visibility of the 'Site not working?' link. r?nhnt11!

Depends on D38637

Comment 5

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f54ffb350ee92d3afbcb8f72ec602be323315b7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023e2d0c4dd7
Part 1: Fixing the hidden state of 'Site not working' link. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/513e87bb151b
Part 2: Remove unnecessary pref of the breakage report UI. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/db1ad513cc3f
Part 3: Fixing the height of the TP switch section when TP is disabled. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/708f0175c5e6
Part 4: Update tests and add a test for check visibility of the 'Site not working?' link. r=nhnt11

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/023e2d0c4dd7
https://hg.mozilla.org/mozilla-central/rev/513e87bb151b
https://hg.mozilla.org/mozilla-central/rev/db1ad513cc3f
https://hg.mozilla.org/mozilla-central/rev/708f0175c5e6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This bug is tagged as a regression but it isn't clear when it regressed. How far back does this go?

Comment 9

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

The regression is introduced by Bug 1562575.