1567122 - [meta] Enable Fission for AWSY

Status: RESOLVED FIXED

(Testing :: Performance, task)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This is a tracking bug for getting the AWSY tp6 tests in CI with Fission enabled.

Comment 1

[Marian Raiciof [:marauder]]

Attachment: Bug 1567122 - Enable Fission for AWSY

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/843409fd89e6
Enable Fission for AWSY. r=perftest-reviewers,sparky

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/843409fd89e6

Comment 4

[Florin Strugariu [:Bebe]]

This bug caused a big regression on AWSY in Bug 1589638

Should we enable fission on the existing awsy tests or add new tests fission specific.

Comment 5

[Razvan Maries]

Backed out as per Marian's request for causing regressions: https://hg.mozilla.org/integration/autoland/rev/9d0c4ad1779dd09b4b0408a61310e5d405e283c6

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/9d0c4ad1779d

Comment 7

[Florin Strugariu [:Bebe]]

== Change summary for alert #23513 (as of Mon, 21 Oct 2019 05:25:30 GMT) ==

Regressions:

18% Images windows10-64-shippable opt stylo tp6 6,878,068.50 -> 8,139,275.80
14% Images linux64 opt stylo tp6 6,458,009.15 -> 7,330,828.01
12% Images linux64-shippable opt stylo tp6 6,507,705.49 -> 7,299,950.92
12% Images macosx1014-64-shippable opt stylo tp6 6,750,109.25 -> 7,540,098.92
9% Heap Unclassified windows10-64-qr opt 51,811,536.49 -> 56,521,406.83
9% Heap Unclassified windows10-64-shippable-qr opt 51,333,835.79 -> 55,759,350.89
7% Images linux64-shippable-qr opt stylo tp6 7,751,036.75 -> 8,293,252.44
7% Images windows7-32 opt stylo tp6 6,590,752.16 -> 7,035,452.73
6% Images linux64-qr opt stylo tp6 7,755,636.86 -> 8,257,524.93
3% Resident Memory windows10-64-shippable-qr opt 557,355,646.42 -> 573,572,767.94
3% Resident Memory windows10-64-qr opt 553,945,067.14 -> 568,312,845.32
2% Resident Memory windows10-64 opt 580,576,227.27 -> 593,643,502.12
2% JS windows7-32 opt 80,259,525.64 -> 81,910,308.26

Improvements:

31% Images linux64-qr opt 8,134,272.88 -> 5,616,021.64
30% Images linux64-shippable-qr opt 8,117,040.11 -> 5,668,693.38
22% Heap Unclassified macosx1014-64-shippable opt stylo tp6 173,419,266.68 -> 134,798,643.19
22% Images windows10-64-qr opt 10,214,294.88 -> 7,952,957.46
22% Images windows10-64-shippable-qr opt 10,208,801.73 -> 8,005,272.61
21% Images macosx1014-64-shippable opt 5,576,268.58 -> 4,407,113.99
20% Heap Unclassified linux64 opt stylo tp6 120,375,140.14 -> 96,785,333.46
19% Heap Unclassified linux64-shippable opt stylo tp6 120,894,832.87 -> 97,722,208.49
18% Images linux64 opt 5,427,284.21 -> 4,426,127.58
18% Images windows7-32 opt 6,020,593.72 -> 4,931,321.60
18% Images linux64-stylo-sequential opt 5,338,943.91 -> 4,380,252.44
17% Images windows7-32-shippable opt 5,907,341.45 -> 4,874,673.61
16% Heap Unclassified windows10-64-qr opt stylo tp6 84,074,802.15 -> 70,847,722.67
16% Heap Unclassified windows7-32 opt 44,176,132.59 -> 37,239,884.59
16% Heap Unclassified windows10-64-shippable-qr opt stylo tp6 84,829,969.88 -> 71,653,099.95
15% Images linux64-shippable opt 5,363,181.28 -> 4,552,530.63
15% Heap Unclassified windows7-32-shippable opt stylo tp6 62,938,368.82 -> 53,635,917.25
15% Resident Memory macosx1014-64-shippable opt stylo tp6 654,596,925.30 -> 557,954,946.32
14% Heap Unclassified windows7-32 opt stylo tp6 62,837,427.74 -> 53,792,158.23
14% Heap Unclassified windows7-32-shippable opt 43,705,220.13 -> 37,493,400.29
14% Resident Memory linux64 opt stylo tp6 865,195,621.19 -> 742,310,129.96
14% Images windows10-64-shippable opt 6,194,464.63 -> 5,315,206.60
14% Heap Unclassified windows10-64-shippable opt stylo tp6 77,421,032.99 -> 66,543,209.95
14% JS windows7-32 opt stylo tp6 179,629,483.04 -> 155,118,982.20
14% Heap Unclassified windows7-32 opt stylo tp6 62,307,901.81 -> 53,836,646.48
13% Resident Memory linux64-shippable opt stylo tp6 867,410,873.46 -> 751,942,152.41
13% JS windows7-32-shippable opt stylo tp6 178,103,325.80 -> 154,492,261.62
13% Explicit Memory macosx1014-64-shippable opt stylo tp6 620,235,455.35 -> 538,400,120.52
13% JS windows10-64-qr opt stylo tp6 236,151,795.80 -> 206,523,061.45
12% Resident Memory windows7-32 opt stylo tp6 771,294,120.19 -> 676,061,158.26
12% Explicit Memory linux64 opt stylo tp6 581,100,680.08 -> 510,165,360.28
12% JS linux64-shippable-qr opt stylo tp6 232,132,783.76 -> 204,523,679.72
12% Explicit Memory linux64-shippable opt stylo tp6 581,433,861.15 -> 512,775,695.85
12% Heap Unclassified linux64-shippable-qr opt stylo tp6 241,688,843.67 -> 213,290,568.11
12% JS linux64 opt stylo tp6 229,069,829.31 -> 202,375,644.91
12% JS macosx1014-64-shippable opt stylo tp6 229,431,864.44 -> 202,789,582.74
11% Explicit Memory windows10-64-qr opt stylo tp6 549,084,743.97 -> 486,054,151.91
11% Resident Memory linux64-shippable-qr opt stylo tp6 1,035,036,091.51 -> 917,744,550.16
11% Resident Memory linux64-qr opt stylo tp6 1,022,111,101.98 -> 908,121,641.84
11% Explicit Memory windows7-32 opt stylo tp6 437,987,980.88 -> 389,963,457.71
11% JS linux64-qr opt stylo tp6 231,399,867.14 -> 206,031,939.70
11% Explicit Memory linux64-shippable-qr opt stylo tp6 708,975,987.41 -> 631,755,576.75
11% JS windows10-64-shippable-qr opt stylo tp6 234,241,615.39 -> 208,836,243.31
11% JS windows10-64 opt stylo tp6 235,082,454.15 -> 209,701,657.12
11% JS linux64-shippable opt stylo tp6 228,489,298.75 -> 204,181,079.25
10% Explicit Memory windows10-64-shippable-qr opt stylo tp6 545,555,326.69 -> 490,150,288.85
10% Explicit Memory linux64-qr opt stylo tp6 703,666,607.82 -> 632,970,492.30
10% Heap Unclassified linux64-qr opt stylo tp6 237,544,276.34 -> 213,668,887.95
10% Resident Memory windows10-64-qr opt stylo tp6 787,583,399.02 -> 709,577,754.05
10% Explicit Memory windows7-32-shippable opt stylo tp6 434,130,502.93 -> 391,616,134.60
10% Resident Memory windows7-32-shippable opt stylo tp6 768,758,234.60 -> 695,362,191.29
9% Resident Memory windows10-64-shippable-qr opt stylo tp6 794,887,915.86 -> 720,850,391.44
9% Explicit Memory windows10-64-shippable opt stylo tp6 522,703,764.65 -> 475,716,291.28
9% Heap Unclassified linux64-shippable opt 85,422,845.01 -> 78,021,275.02
9% Heap Unclassified linux64-stylo-sequential opt 84,817,312.68 -> 77,587,043.71
8% Resident Memory windows10-64-shippable opt stylo tp6 734,893,490.77 -> 676,371,965.74
8% JS windows10-64-shippable opt stylo tp6 224,881,573.20 -> 207,460,664.83
7% Heap Unclassified linux64 opt 84,988,137.28 -> 78,783,168.88
6% Images windows10-64 opt 6,180,995.83 -> 5,809,932.52
3% Heap Unclassified macosx1014-64-shippable opt 125,800,182.45 -> 121,698,052.39

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23513

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Florin Strugariu [:Bebe] (needinfo me) from comment #4)

This bug caused a big regression on AWSY in Bug 1589638

Should we enable fission on the existing awsy tests or add new tests fission specific.

Sorry for the delay; Marian's latest approach -- to enable it on the existing tests -- seems like the way to start.

Comment 9

[Eric Rahm [:erahm]]

What we want is a variant of the awsy-tp6 tests that has fission enabled. This will let us compare fission vs non-fission memory usage. Eventually when fission rolls out we can get rid of the non-fission variant. This is similar to how we tested e10s.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/776dc76ec598
Enable Fission for AWSY r=perftest-reviewers,stephendonner,sparky

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Why has this been landed without a proper review of a Marionette peer? No-one of the reviewers list is actually a peer of Marionette!

Comment 12

[Marian Raiciof [:marauder]]

Hi Henrik,

I did the landing on this one.
I can talk to a code sheriff to back it out. Who should i add as a reviewer from Marionette ?
Thanks!

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, please backout and add '#webdriver-reviewers' as reviewer.

Comment 14

[Marian Raiciof [:marauder]]

I talked to code sheriffs and they will perform the back out.
I added the webdriver-reviewers, thanks!

Comment 15

[Andreea Pavel [:apavel]]

Backed out on request by Marian for landing without proper peer review

Backout: https://hg.mozilla.org/integration/autoland/rev/c0aebe5e0bc0a4be9e3f275cd5a93e0149875fba

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9816255bcde6
Enable Fission for AWSY r=perftest-reviewers,stephendonner,sparky,erahm

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9816255bcde6