Master password prompt before copying/revealing passwords in about:logins
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | wontfix |
firefox70 | --- | verified |
People
(Reporter: MattN, Assigned: jaws)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [passwords:management] [skyline])
Attachments
(2 files)
To prevent snooping and parity with the old management UI, we need to prompt for MP before copying/revealing passwords.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Backed out 2 changesets for causing failures in browser_masterPassword.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/af37a24bac5db7671dd5394173584789567d2304
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258428041&repo=autoland&lineNumber=2981
[task 2019-07-26T01:46:37.013Z] 01:46:37 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | Logins should be displayed when MP is set and authenticated -
[task 2019-07-26T01:46:37.018Z] 01:46:37 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | Dialog is the Master Password dialog -
[task 2019-07-26T01:46:37.019Z] 01:46:37 INFO - Master Password dialog shown and canceled
[task 2019-07-26T01:46:37.021Z] 01:46:37 INFO - Clicking copy password button again
[task 2019-07-26T01:46:37.022Z] 01:46:37 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | Dialog is the Master Password dialog -
[task 2019-07-26T01:46:37.023Z] 01:46:37 INFO - Buffered messages finished
[task 2019-07-26T01:46:37.025Z] 01:46:37 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | Test timed out -
[task 2019-07-26T01:46:37.026Z] 01:46:37 INFO - GECKO(2216) | MP change from omgsecret! to
[task 2019-07-26T01:46:37.027Z] 01:46:37 INFO - GECKO(2216) | MEMORY STAT | vsize 20974919MB | residentFast 1031MB
[task 2019-07-26T01:46:37.029Z] 01:46:37 INFO - TEST-OK | browser/components/aboutlogins/tests/browser/browser_masterPassword.js | took 90269ms
[task 2019-07-26T01:46:37.030Z] 01:46:37 INFO - checking window state
[task 2019-07-26T01:46:37.031Z] 01:46:37 INFO - GECKO(2216) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object
[task 2019-07-26T01:46:37.033Z] 01:46:37 INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_openFiltered.js
Assignee | ||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f122ed713cb
https://hg.mozilla.org/mozilla-central/rev/04a64d6707ea
Comment 7•5 years ago
|
||
I have verified this issue on the latest Nightly 70.0a1 (2019-07-31) (64-bit) on Windows 10 x64, Windows 7 x64, MacOS 10.14 and Ubuntu 18.04.
- The master password pop-up is correctly displayed when the "Show Password" and "Copy password" buttons are clicked. The password is not revealed/copied until the master password is entered.
Updated•5 years ago
|
Updated•3 years ago
|
Description
•