Closed Bug 1567273 Opened 5 years ago Closed 5 years ago

Turn on DS for DE

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Iteration:
72.3 - Nov 18 - Dec 1
Tracking Flags:
Tracking Status
firefox72 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Regressed 1 open bug)

Details

(Keywords: github-merged)

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5367
52 bytes, text/x-github-pull-request
Details | Review
Bug 1567273 - Pref to enable lang config for Discovery Stream layouts
47 bytes, text/x-phabricator-request
Details | Review

This might be a bit more complex than en-CA because it's a DE specific feed.

Both DE and en-CA are with spocs off.

Another aspect is the hardcoded layout has english strings that might want to be exposed as fluent strings instead ?

https://searchfox.org/mozilla-central/rev/da855d65d1fbdd714190cab2c46130f7422f3699/browser/components/newtab/lib/DiscoveryStreamFeed.jsm#1257-1259

Also, TopStories for DE does not show navigation links.

Priority: -- → P1
Assignee: nobody → sdowne
Iteration: --- → 70.2 - Jul 22 - Aug 4
Points: --- → 3
Iteration: 70.2 - Jul 22 - Aug 4 → 70.3 - Aug 5 - 18
Priority: P1 → P2
Depends on: 1573905
Iteration: 70.3 - Aug 5 - 18 → ---
Iteration: --- → 72.1 - Oct 21 - Nov 3
Priority: P2 → P1
Iteration: 72.1 - Oct 21 - Nov 3 → 72.2 - Nov 4 - 17
Iteration: 72.2 - Nov 4 - 17 → 72.3 - Nov 18 - Dec 1
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/b76cec570edf
Pref to enable lang config for Discovery Stream layouts r=gvn
Blocks: 1598724

https://hg.mozilla.org/mozilla-central/rev/b76cec570edf

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

I have verified that the Discovery Stream with 1 row variant is displayed on the "de-DE" locale with the region set to "DE", using the steps from here on Firefox 72.0a1 (Build-ID 20191124230652) using Windows 10 x64, macOS 10.15.1, and Arch Linux x64. No spocs, english strings, or navigation components under cards are displayed and the en-US and en-CA locales are unaffected by this change.

Status: RESOLVED → VERIFIED
status-firefox72: fixed → verified
Regressions: 1608656
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: