1567320 - Update StubAttribution service to handle additional parameters

Status: RESOLVED FIXED

(Cloud Services :: Operations: Product Delivery, task)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

In bug 1515172 we are adding 2 additional attributes to the stub attribution handlers in the browser. We need to ensure that the stubattribution service (https://github.com/mozilla-services/stubattribution) will handle these.

The parameters are:

funnel_experiment: name/id of the enrolled experiment
funnel_variation: name/id of the variation cohort used in the enrolled experiment

Expected behavior:

• If utm_* parameters are present, continue validating, passing them through in the same manner as before.
• If these two additional parameters are present, regardless of the presence of any other parameters, a) validate they are a safe character set and b) pass them through.

There are likely edge cases to consider; we can identify/discuss below.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

:oremj, can you review this bug (and the one it blocks) and help get it articulated well enough to implement?

Comment 2

[Shane Caraveo (:mixedpuppy)]

Based on comments in the git issue, the attribution service will look for experiment and variation.

Comment 3

[Jeremy Orem [:oremj]]

https://github.com/mozilla-services/stubattribution/pull/95 should cover this.

Comment 4

[Jeremy Orem [:oremj]]

What's the status of this project. I can merge the PR and deploy if it looks good on your side.

Comment 5

[Ron Manning]

@oremj & @hoosteeno: Have we been able to get the code reviewed so we can get this completed?

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

I have reviewed it for alignment with other pieces of the attribution puzzle. With a few changes I think it's good to go.

Comment 7

[Jeremy Orem [:oremj]]

I've made the suggested changes:

• Increase code length to 600
• s/funnel_//
  Please re-review when you have a chance.

Comment 8

[Jeremy Orem [:oremj]]

Alright, I've merged the PR and cut a release.

Tim, when do you want me to deploy this?

Comment 9

[Tim Spurway [:tspurway]]

:oremj - anytime you are ready (except Friday X-)

The Bedrock team is landing the UA parsing and encoding for the attribution string in https://github.com/mozilla/bedrock/issues/8405 and that is independent of this bug, so go ahead and land it asap. Thanks, :oremj !

Comment 10

[Jeremy Orem [:oremj]]

This was deployed at 9am this morning.

It looks like the bedrock settings went live on Thursday. While the two versions were out of sync stub attribution was primarily redirecting to plain installers instead of attributed installers. If there is any metric wonkyness during that period, this is the reason.