1567349 - Background-position-y parsing WPT is bogus.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

The right serialization for calc(10px - 0.5em) is calc(-0.5em + 10px).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1567349 - Fix various bogus WPTs that test wrong calc serialization. r=#style

https://drafts.csswg.org/css-values-4/#calc-serialize:

Sort the terms in the following order:
The number, if present
The percentage, if present
The dimensions, ordered by their units ASCII case-insensitive alphabetically
Comparison, trigonometric and exponential functions, in the order they appeared in the original expression.

So em goes before px. I filed https://github.com/w3c/csswg-drafts/issues/4129 on
the second part of that algorithm not matching any browser.

These are tests that are marked as only failing in Firefox because we're the
only following the spec. #funtimes

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bbd8e64cb9c
Fix various bogus WPTs that test wrong calc serialization. r=heycam

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0bbd8e64cb9c

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17933 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged