Use --panel-separator-color on customize mode overflow menu separator
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ntim, Assigned: bugtastico, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
Screenshot
rgba(0,0,0,0.1) should be var(--panel-separator-color)
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
Hi I would like to be assigned this bug. This would be my first attempt at contributing to open source and Mozilla and this looks like a simple starter bug! I have my local Firefox built on Windows 10, and applied the change and committed to my local Mercurial. Not sure of the next steps whether I need to write a test or submit to Phabricator or something else. I look forward to your advice!
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to bugtastico from comment #1)
Hi I would like to be assigned this bug. This would be my first attempt at contributing to open source and Mozilla and this looks like a simple starter bug! I have my local Firefox built on Windows 10, and applied the change and committed to my local Mercurial. Not sure of the next steps whether I need to write a test or submit to Phabricator or something else. I look forward to your advice!
Great to hear! This change is simple enough that you shouldn't need to write a test. The next step would be submitting your commit to Phabricator. Please let me know if you have any questions :)
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a202452e8a69 Use --panel-separator-color on customize mode overflow menu separator r=ntim
|
|
Reporter | |
Comment 5•5 years ago
|
||
Thanks for working on this! Your patch should be in tomorrow's nightly and you should see the color of the separator in comment 0 change on the dark theme :) If you're looking for another bug, bug 1524872 is a good candidate.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Thanks, I'll give that one a go next!
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•