1567686 - (New Password Manager) Passwords imported from IE, usernames and passwords appear as "MEoEE...." in Password Manager until reopen the password manager

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Alice0775 White]

Reproducible: always

Steps to reproduce:

1. Hamburger Menu -> Login and Passwords
2. Meatball Menu -> Import Passwords...
3. Select "Microsoft Internet Explorer" and proceed to import passwords

Actual Results:
usernames and passwords appear as encrypted text "MEoEE..."
Reopen the password manager will appear as plain text as expected.

Expected Results:
Not encrypted.

Comment 1

[Matthew N. [:MattN]]

Seems like we aren't decrypting when subscribing to updates.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I don't see this as a regression of the new about:logins page. From debugging this, it is happening because addLogins is adding the login with the username and password pre-encrypted and the notification that gets sent out is sending out the encrypted fields instead of the decrypted values.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1567686 - Login addition notifications from batch imports should use the plaintext values. r?MattN

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/328a9d64b357
Login addition notifications from batch imports should use the plaintext values. r=MattN

Comment 5

[Matthew N. [:MattN]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)

I don't see this as a regression of the new about:logins page. From debugging this, it is happening because addLogins is adding the login with the username and password pre-encrypted and the notification that gets sent out is sending out the encrypted fields instead of the decrypted values.

It wasn't visible in the old UI since it didn't use the data from the notifications, only the notification itself to know it needed to update the list.

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/328a9d64b357

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190918215055) (64-bit) and on the latest Firefox Beta 70.0b7 (Build ID: 20190916074538) (64-bit) on Windows 10 x64.

• The saved logins imported from IE are correctly displayed and are not encrypted.