1567770 - configuration texts/area/pane for filelink provider shouldn't use user set color for reading messages

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird Daily 70.0a1 and 68.0b5 on Windows 8.1

The configuration texts for filelink providers shouldn't use user set color for reading messages.

Steps to reproduce (Daily):

1. Open Thunderbird's Options/Preferences from the Extras/Tools menu or the button with the three horizontal bars.
2. Select the pane "General" on the left.
3. Scroll down to "Language & Appearance"
4. Click on "Colors".
5. Set a custom color for "Text".
6. On the left, click on "Composition.
7. Scroll down to "Attachments":
8. Click "Add WeTransfer".
9. Select "WeTransfer" from the list if necessary.

Actual result:
Text "WeTransfer is the simplest way to send your files around the world." is styled in the color fore message reading.

Expected result:
Text color used like for the other Options texts.

Comment 1

[Richard Marti (:Paenglab)]

This text is inside of a iframe and styled from the extension. The preferences style sheets have no access to it.

Comment 2

[Geoff Lankow (:darktrojan)]

You're right but we could explicitly state the colours in the extension's stylesheet. Especially for WeTransfer which is supposed to be part of the product.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1567770-wetransfer-fixed font.patch

Okay, how about this? I've used the colours we use in the prefs and use a fixed font height to not depend on the content font settings.

When this is okay, you could do the same with your other cloudfile extensions on ATN.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b56bdad8ff02
Set a fixed text color and size in WeTranfer extension. r=darktrojan CLOSED TREE DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

Someone will need to manage uplift requests here.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9079956 [details] [diff] [review]
1567770-wetransfer-fixed font.patch

Not checked on beta or ESR but it should cleanly apply as there should be no changes between the branches.

Comment 7

[Jorg K (CEST = GMT+2)]

Wayne, this hasn't spent time on beta, but I suggest to take it straight to TB 68.0 ESR. You're OK with that, it's just a bit of CSS which will make the product look better?

Comment 8

[Jorg K (CEST = GMT+2)]

TB 69 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/08b4ef086c49a56e2e4221cc21bc8dd7972afede

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/149fb2930dfdfa2ea2876ed1e585dfc89e992d55