Closed
Bug 1567783
Opened 5 years ago
Closed 5 years ago
Error Console has Browser Console as title
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)
VERIFIED
FIXED
Thunderbird 70.0
People
(Reporter: aryx, Assigned: aceman)
References
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
jorgk-bmo
:
review+
aryx
:
feedback+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Thunderbird 70.0a1 latest version and 68.0b5
Bug 1450465 added code to update the error console's title with "Error Console" instead of "Browser Console". This doesn't work anymore. Updating chrome://devtools/content/webconsole/browserconsole.xul with chrome://devtools/content/webconsole/index.html is not sufficient.
Flags: needinfo?(acelists)
|
||
Updated•5 years ago
|
tracking-thunderbird68:
--- → +
Flags: needinfo?(richard.marti)
|
||
Comment 1•5 years ago
|
||
This is something for aceman and not for me.
Flags: needinfo?(richard.marti)
|
||
Updated•5 years ago
|
Severity: normal → minor
status-thunderbird68:
--- → wontfix
status-thunderbird_esr68:
--- → affected
tracking-thunderbird_esr68:
--- → ?
Version: unspecified → 68
This works for me.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Flags: needinfo?(acelists)
Attachment #9084513 -
Flags: feedback?(aryx.bugmail)
|
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9084513 [details] [diff] [review]
1567783.patch
Review of attachment 9084513 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not sure Aryx is building TB these days. WFM :-)
::: mail/components/mailGlue.js
@@ +58,5 @@
> Services.obs.addObserver(this, "chrome-document-global-created");
>
> // Inject scripts into some devtools windows.
> function _setupBrowserConsole(domWindow) {
> + // Browser Console is a HTML document.
I'll fix the comment, should be "an XHTML document". It would also be "an HTML document", since the a/an rule is not based on vowels/consonants but on how the thing sounds: A unique/united country, a yellow car, a horrible day, an ace, an honest person, an hour ago, etc.
Attachment #9084513 -
Flags: review+
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed
|
Reporter | |
Comment 5•5 years ago
|
||
Comment on attachment 9084513 [details] [diff] [review]
1567783.patch
Thanks, looks as expected (modified mailGlue.js in the omni.ja of a Daily build to test).
Attachment #9084513 -
Flags: feedback?(aryx.bugmail) → feedback+
|
|
||
Updated•5 years ago
|
Attachment #9084513 -
Flags: approval-comm-esr68?
Attachment #9084513 -
Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fed5e95f3b95
Overwrite Browser console dialog title with Error console again. r=jorgk
|
|
||
Updated•5 years ago
|
status-thunderbird68:
wontfix → ---
status-thunderbird69:
--- → affected
status-thunderbird70:
--- → fixed
tracking-thunderbird68:
+ → ---
Target Milestone: --- → Thunderbird 70.0
|
|
||
Comment 7•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Attachment #9084513 -
Flags: approval-comm-esr68? → approval-comm-esr68+
|
|
||
Comment 8•5 years ago
|
||
|
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•