1567927 - (ujmc-test-code-coverage) get activity-stream unit tests hooked into mc-wide code coverage

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

After we get the activity-stream repo unit-tests working in taskcluster/treeherder, it would be nice to get them hooked into the tree-wide code-coverage infrastructure.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

karma-coverage-istanbul-reporter, which is what we're already using, can output json stuff. There are at least two things we can do here (we may want to do both depending on how the tree-wide coverage infrastructure works):

• make the reporter emit json, and teach try-runner to turn the newtab tests red when coverage thresholds are violated
• tie directly into the tree-wide code coverage infrastructure (which may surface the coverage info in Phab, I'm not sure)

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Something landed in m-c today that busted our code coverage by dropping it below the level we have listed. This will presumably happen again from time-to-time until we get m-c code-coverage implemented. Dropping priority on this bug so that we will re-triage it..

Comment 3

[Punam Dahiya [:pdahiya]]

Will fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1581165#c0 help with code coverage issue reported in previous comment.

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1567927 - Report karma code coverage failures with existing istanbul thresholds r?dmose

Depends on D60414

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Punam Dahiya [:pdahiya] from comment #3)

Will fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1581165#c0 help with code coverage issue reported in previous comment.

No; we need still need to use the patch that interprets the code-coverage output. I'll be reviewing Ed's patch attached to this bug soon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dbea7129a30
Report karma code coverage failures with existing istanbul thresholds r=dmose

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0dbea7129a30