Closed Bug 1568480 Opened 2 years ago Closed 2 years ago

remove grid usage from comm/calendar/base/content/dialogs/calendar-event-dialog-recurrence.xul

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324
Attachment #9080303 - Flags: feedback?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9080303 [details] [diff] [review]
Bug-1568480_remove-grid-calendar-event-dialog-recurrence.patch

Review of attachment 9080303 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry but this is also not tabular data, it's simply layout so should not use <table>
Attachment #9080303 - Flags: feedback?(mkmelin+mozilla) → feedback-
Comment on attachment 9086667 [details] [diff] [review]
Bug-1568480_remove-grid_calendar-event-dialog-recurrence-xul.patch

Review of attachment 9086667 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  r+  

(Unrelated to this patch, while testing I noticed that the bold numbers in the minimonths in this dialog do not reliably update.  I noticed trouble when doing monthly patterns and limiting it to a few occurrences etc.  Seems like it gets off and then gets back on again sometimes.  Maybe there's already a bug for this.)
Attachment #9086667 - Flags: review?(paul) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f05b6f4ed6dc
remove grid usage from calendar-event-dialog-recurrence.xul. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.