1568516 - In StaticPrefs, uint32_t cannot have a mirror type of 'never'

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I don't know if this is intentional (and missing documentation on why) or a bug.

Comment 1

[Nicholas Nethercote [inactive]]

Definitely sounds like a bug. I'll take a look today.

Comment 2

[Nicholas Nethercote [inactive]]

I can't reproduce the problem. I just added this entry to StaticPrefList.yaml:

- name: aaa.bbb.ccc
  type: uint32_t
  value: 123
  mirror: never

and it worked fine. And I can't see anything in generate_static_pref_list.yaml that would cause uint32_t to be treated differently to other types.

(Actually, my attempt didn't work at first because I mistyped uint32_t as uint32. Might you have done the same thing?)

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

# Dynamically tune the resolution of the timer reduction for both of the two above prefs
- name: privacy.resistFingerprinting.reduceTimerPrecision.microseconds
  type: uint32_t
  value: 1000
  mirror: never

0:08.00 /home/tom/Documents/moz/mozilla-unified-2/obj-x86_64-pc-linux-gnu/dist/include/mozilla/StaticPrefList.h:5619:1: error: use of undeclared identifier 'SetPref_uint32_t'; did you mean 'SetPref_int32_t'?
0:08.00 PREF("privacy.resistFingerprinting.reduceTimerPrecision.microseconds", uint32_t, 1000)

Comment 4

[Nicholas Nethercote [inactive]]

Ah, I didn't wait long enough... my build eventually failed too. The fix should be straightforward.

Comment 5

[Nicholas Nethercote [inactive]]

Turns out it's unrelated to bug 1564724. The problem would have occurred if a non-mirrored uint32_t pref was added before the YAML file was introduced.

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Bug 1568516 - Allow a `uint32_t` static pref with a mirror value of `never`. r=KrisWright

There was a missing setter function for this combination, which hasn't been
used before.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65edb8712385
Allow a `uint32_t` static pref with a mirror value of `never`. r=KrisWright

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/65edb8712385