1564724 - Generate StaticPrefList.h

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

Generating StaticPrefList.h will help with some other things, like:

• splitting it into pieces to reduce recompilations (bug 1563139);
• improving Rust access to prefs (bug 1563555);
• making it harder to mess up static prefs (previously attempted in bug 1563146)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1564724 - Generate StaticPrefList.h from StaticPrefList.yaml. r=glandium

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1564724 - Tweak StaticPrefList.h. r=glandium

Minor things to ease the transition to StaticPrefList.yaml.

• Rename apz_touch_drag_enabled() to the correct apz_drag_touch_enabled().

• Change some trailing C-style comments to C++-style comments. This makes life
  easier for the script I wrote to convert StaticPrefList.h to
  StaticPrefList.yaml, which will be used for the next patch.

• Avoid comments on #define lines, because they aren't handled in the YAML
  input.

• Convert a multi-line #if condition to a single line, because
  Preprocessor.py doesn't handle multi-line conditions.

• Remove one unnecessary #undef PREF_VALUE directive.

• Move intl.charset.detector.iso2022jp.allowed to the correct section, so the
  YAML processing script won't complain.

• Change an int pref to int32_t, again so the YAML processing script won't
  complain.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1564724 - Remove the old hand-written StaticPrefList.h. r=glandium

Depends on D37526

Comment 4

[Nicholas Nethercote [inactive]]

glandium: In case it's not clear, the order of these patches is "Tweak...", Generate...", "Remove...", but Phabricator isn't showing that because I originally pushed just the "Generate..." patch.

Also note that the "Generate..." patch has a couple of njn: comments reordering things in StaticPrefList.h. Once bug 1565110 lands they will go away.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Script for converting StaticPrefList.h to StaticPrefList.yaml

Comment 6

[Nicholas Nethercote [inactive]]

Also note that the "Generate..." patch has a couple of njn: comments reordering things in StaticPrefList.h. Once bug 1565110 lands they will go away.

Bug 1565110 landed, and I have updated the loaded patches accordingly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63d7dc4650c3
Tweak StaticPrefList.h. r=glandium

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d0e35ab6850
Generate StaticPrefList.h from StaticPrefList.yaml. r=glandium

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/63d7dc4650c3
https://hg.mozilla.org/mozilla-central/rev/3d0e35ab6850

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5382cec9e306
Remove the old hand-written StaticPrefList.h. r=glandium

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5382cec9e306