1568692 - Show a page like what's new on startup once but not dependent on major version bump

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

This could be used to show a Moment page that some other system sets the appropriate pref to trigger this opening behavior on startup.

This could be in addition to bug 1556811 as update-server can set startup.homepage_override_url on first run of a new version. Where a new one-time pref might only be set after first run thus triggering only on subsequent runs.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1568692 - Show a page like what's new on startup once but not dependent on major version bump

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f44cd2d3a35b
Show a page like what's new on startup once but not dependent on major version bump r=k88hudson

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f44cd2d3a35b

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1568692 - Show a page like what's new on startup once but not dependent on major version bump r=k88hudson

Mostly like m-c except browser_bug538331.js has no SpecialPowers on beta.

Comment 5

[Ed Lee :Mardak]

Comment on attachment 9085239 [details]
Bug 1568692 - Show a page like what's new on startup once but not dependent on major version bump r=k88hudson

Beta/Release Uplift Approval Request

• User impact if declined: Not able to see "moment" messaging
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) create new string pref browser.startup.homepage_override.once set to {"url":"https://www.mozilla.org/%LOCALE%/etc/firefox/retention/thank-you-a/"}

2. restart firefox
3. see both a thank you page (https://www.mozilla.org/en-US/etc/firefox/retention/thank-you-a/) and home page tabs

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): New pref with no default value, so no immediately changed behavior.
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085239 [details]
Bug 1568692 - Show a page like what's new on startup once but not dependent on major version bump r=k88hudson

Work in support of the approved relationship scoping projects targeting Fx69. Approved for 69.0b14.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a71ae2fd825

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue during the feature testing. We can confirm this bug is solved, we used Fx 70.0a1, Fx 69.0b15 across the following platforms: Ubuntu 18.04 LTS, macOS 10.13.6 and Windows 10 x64.