1567601 - (moments-page-69) [meta] New "Moments" Page

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5251

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1567601 - New "Moments" Page

Includes 15 activity-stream commits:

27b79564 Bug 1561536 - Add new message schema and template type for feature callouts (#5133)
d8570e05 Bug 1561540 - CFR messages should have a priority field that allows sorting (#5156)
7c9f5603 Bug 1564898 - Use UpdateManager to get the earliest Firefox version used (#5165)
6ebba35b Bug 1564811 - Badge actions can define a timeout delay after which the action is executed (#5170)
90b5eea2 (nobug) Move the What's New and Badge test messages to PanelTestProvider.jsm (#5171)
23e918ca Port 1561537 - Add badge/feature-callout style that matches the design spec r=r1cky
28bf2f0d (nobug) - Restore the default icon style after removing the badge (#5180)
ffcb9a2a Bug 1561554 - Add telemetry events for notification badges (#5176)
4fcf6451 Bug 1566372 - Listen for pref changes as a way to trigger notifications (#5191)
993d0446 Bug 1571818 - handleMessageRequest method does not consider trigger params (#5226)
c42d699c Port 1570935 - Remove clip-path property for causing performance regression r=k88hudson
e125087c Port 1533846 - Clear WeakMap entries for Messaging System notifications r=k88hudson

84abc9de Bug 1569020 - Add a new badge action for setting homepage_override pref (#5207)
f4878d99 Bug 1571846 - Moments pref reset issue (#5223)
2febea0f Bug 1573953 - Don't add impressions for moments page pref check (#5256)

Comment 3

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We'll use this bug to uplift the "moments" feature for relationships kpi

Comment 4

[Ed Lee :Mardak]

Comment on attachment 9085278 [details]
Bug 1567601 - New "Moments" Page

Includes 13 bugs https://bugzilla.mozilla.org/buglist.cgi?bug_id=1561536%2C1561540%2C1564898%2C1564811%2C1561537%2C1561554%2C1566372%2C1571818%2C1570935%2C1533846%2C1569020%2C1571846%2C1573953

Beta/Release Uplift Approval Request

• User impact if declined: Not seeing a "moments" message / page when starting Firefox
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See QA scope: https://docs.google.com/document/d/1r_Zx75budKb4ZgBKEyIuXSR47vm-OkW0FE50PwS53Q0/edit#heading=h.dap0ja9iexpn
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Some of the changes were implemented closely with the What's New Panel, which is not being uplifted, so parts of the patch for uplift needed to be reworked. The code has been on nightly, but the combination of setting up remote staging messages and relatively exact timings (e.g., profile age = 365 days and checking every 5 minutes) makes it hard to manually test end-to-end. Automated tests and simulated tests (devtools) are more straightforward and do pass. The feature is also remotely controlled, so that lessens the risk.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b4d14dc08d081ee2e78c4501f6fa456e4955194

• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085278 [details]
Bug 1567601 - New "Moments" Page

Work in support of the approved relationship scoping projects targeting Fx69. Approved for 69.0b14.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/feeaf170fca669a675eff2cb16bd56b0a329b508