1568833 - Make the "screenshot node" inspector feature work with oop frames

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Patrick Brosset <:pbro>]

With Fission, it must still be possible to grab screenshots of single elements, even when they are in oop iframes, from the inspector's context menu.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Comment 3

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission Beta milestone (M7).

Comment 4

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m3-mvp bugs to Fission MVP milestone.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1568833 - [devtools] Fix helper_screenshot_node helper. r=jdescottes.

The waitUntilScreenshot wasn't waiting for a new screenshot to be taken, and
if a test took 2 screenshots, it would always return the first one. This is
fixed by managing an array of the downloads we already waited for.

The test was also assuming the dpr of the screen was always 1, which was making
the test fail when running on a machine with a higher dpr screen (e.g. a retina screen).
The assertion for the width and height are updated to take dpr into account.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1568833 - [devtools] Make Screenshot Node context menu item fission-compatible. r=jdescottes.

Retrieve the target in which the selected node lives in order
to get the right screenshotFront.

There was already a test checking that taking a node in an iframe was working,
but it was a same-origin iframe.
We modify the test so it checks both same-origin and remote iframe.

Depends on D101437

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35d059b7f9da
[devtools] Fix helper_screenshot_node helper. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/b78f6648ade5
[devtools] Make Screenshot Node context menu item fission-compatible. r=jdescottes.

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/35d059b7f9da
https://hg.mozilla.org/mozilla-central/rev/b78f6648ade5

Comment 10

[Chris Peterson [:cpeterson]]

This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.