1568840 - Make the computed-view able to display styles for any selected node, even when those nodes are in oop iframes

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P1)

Description

[Patrick Brosset <:pbro>]

With fission, and once bug 1560200 is fixed, we'll be able to select nodes in the inspector that may live in out of process iframes.

When this happens, the computed-view must continue being able to display the corresponding computed style.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1568840 - WIP getting the contextual pageStyleFront

Depends on D42640

Comment 2

[Patrick Brosset <:pbro>]

Not working on it more at the moment beyond this early exploration. I might pick this up again later unless someone beats me to it, but for now this isn't the most urgent thing.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1568840 - Use PageStyle from the currently selected element in the computed view.

Make the PageStyleFront be a singleton managed by the inspector front,
like highlighters and walker.
It helps keep the Computed View code synchronous as it is highly sensible
to race condition. A simple event loop spin make a throw during tests.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=264702278&revision=504c8f7d04cd944fd71aa65ad31b3623f6f6a0d4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb8407a35b11
Use PageStyle from the currently selected element in the computed view. r=pbro,jdescottes

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb8407a35b11

Comment 7

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732