Closed Bug 1568840 Opened 2 years ago Closed 2 years ago

Make the computed-view able to display styles for any selected node, even when those nodes are in oop iframes

Categories

(DevTools :: Inspector, enhancement, P1)

enhancement

Tracking

(Fission Milestone:M4, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: pbro, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission dt-fission-m1)

Attachments

(1 file, 1 obsolete file)

With fission, and once bug 1560200 is fixed, we'll be able to select nodes in the inspector that may live in out of process iframes.

When this happens, the computed-view must continue being able to display the corresponding computed style.

Component: Inspector → Inspector: Computed
Priority: P3 → P2
Whiteboard: dt-fission

Depends on D42640

Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: P2 → P1

Not working on it more at the moment beyond this early exploration. I might pick this up again later unless someone beats me to it, but for now this isn't the most urgent thing.

Assignee: pbrosset → nobody
Status: ASSIGNED → NEW
Priority: P1 → P2
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: dt-fission-reserve → dt-fission

Make the PageStyleFront be a singleton managed by the inspector front,
like highlighters and walker.
It helps keep the Computed View code synchronous as it is highly sensible
to race condition. A simple event loop spin make a throw during tests.

See Also: → 1579134
See Also: → 1579137
See Also: → 1579139
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb8407a35b11
Use PageStyle from the currently selected element in the computed view. r=pbro,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
Attachment #9086654 - Attachment is obsolete: true
Whiteboard: dt-fission → dt-fission dt-fission-m1
Component: Inspector: Computed → Inspector
You need to log in before you can comment on or make changes to this bug.