1568857 - Make the layout-view able to display information about any selected node, even when those nodes are in oop iframes

Status: RESOLVED FIXED

(DevTools :: Inspector: Layout, enhancement, P1)

Description

[Patrick Brosset <:pbro>]

With fission, and once bug 1560200 is fixed, we'll be able to select nodes in the inspector that may live in out of process iframes.

When this happens, the layout-view must continue being able to display the corresponding information. In particular:

• the box-model must continue to display the various box region sizes, and allow them to be edited by the user
• the flexbox inspector must continue to display item and container information
• the grid inspector must continue to display the list of grids on the entire page (even those found in oop frames), let users select one or multiple grids, change their colors, select them in the inspector, and display the mini outline.

Comment 1

[Alexandre Poirot [:ochameau]]

This is going to be slightly more complex than Rules and Computed view.
We may want to split this into 3:

• box model
• flex
• grid

Box model should be fixable as easily as Computed and Rules.
But Flex and Grid will require multiplexing requests to all the targets:

• For example in grids:
  https://searchfox.org/mozilla-central/source/devtools/client/inspector/grids/grid-inspector.js#302-305
  We would have to call getGrids for all the targets, otherwise, it will only report grids of the top level document.
• And flex
  https://searchfox.org/mozilla-central/source/devtools/client/inspector/flexbox/flexbox.js#460
  We would most likely have to fetch contextual highlighters and I'm wondering if that will depend on the highlighters refactoring?

Comment 2

[Patrick Brosset <:pbro>]

We will also have to figure out what we do about the ReflowTracker, which is used by the grid inspector. See bug 1580463.
The box-model also uses it, but in a different way: it only cares about reflows that happen in the target where the current node lives.
The grid inspector however needs to know whenever a reflow occurs in any target, since that may result in the list of grids being different.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: Bug 1568857 - Get the grids from all current targets; r?ochameau!

Comment 4

[Patrick Brosset <:pbro>]

Attachment: Bug 1568857 - Use the contextual highlighter in the box-model; r?ochameau!

Depends on D45524

Comment 5

[Patrick Brosset <:pbro>]

Attachment: Bug 1568857 - Get flexbox information from the right target; r?ochameau!

The flexbox inspector is different from the grid inspector in that it
does not list all of the flexbox layouts on the page. In D45524 we needed
to list all of the LayoutFronts to retrieve all of the GridFronts in the
page. However here, we do not need to do this. We only need to get the
LayoutFront contextual to the NodeFront currently selected.

I also took this opportunity to remove an old backward-compatibility
check called hasGetCurrentFlexbox which was no longer required since it
guarded a feature added in Fx60.

Depends on D45525

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480d76f75c5e
Get the grids from all current targets; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/44d1f79adbcd
Use the contextual highlighter in the box-model; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4809391c9f30
Get flexbox information from the right target; r=ochameau

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/480d76f75c5e
https://hg.mozilla.org/mozilla-central/rev/44d1f79adbcd
https://hg.mozilla.org/mozilla-central/rev/4809391c9f30

Comment 8

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732