156886 - Bookmarks and proxy icon should be different for local files

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Stephane Moureau]

I think that the small icons that are on the left on Bookmarks menu items (menu and 
Sidebar) should be different when the file is a local file.
I suggest using a small blank page with a metal hard-disk box icon instead of a blank 
page with a blue earth.

Comment 1

[Greg K.]

I guess the Chimera developers should decide whether that icon is simply a basic
URL proxy icon and unchanging regardless of protocol, or whether it can and
should change per protocol accessed (http, file, ftp, etc.).

Comment 2

[Lauri Kieksi]

If it doesn't change, then it's basically useless. Reminds me of the old days,
when bookmark menus got icons, and everyone was like "so what" since they all
looked the same. It actually makes bookmark names harder to read, since the
first symbol is not the first character of the name, but instead a generic icon
that never changes. The icon needs to be dynamic or go away.

Comment 3

[saari (gone)]

fair point, with the exception that it helps reenforce the association of a
bookmark with the icon, which is useful if you don't know you can drag them
around, etc.

->pinkerton what say you?

Comment 4

[Mike Pinkerton (not reading bugmail)]

yeah, i think they should change. for local files, we should try to get the icon
from the finder (though maybe in the background).

Comment 5

[Mike Pinkerton (not reading bugmail)]

simon is messing with favicon stuff, maybe he can hack in icons for local files
while he's at it

Comment 6

[Gabriel Radic]

Great idea, I'm voting for it.

Comment 7

[Jasper]

Why not change the globe into a house on the bookmark icon when the file is a
local file? That would also mean that the default Camino site icon (globe) would
need to change to a local file icon (house) when accessing a local file, right?

Comment 8

[Lauri Kieksi]

Using a house icon might not be very smart since Mac OS X uses the house icon to
refer explicitly to the top level of a user's Home directory, ie. "~/", and not
the user's machine in general.

A better choice might be a blank file icon, or alternatively the iMac icon used
by the Finder to refer to "Computer", ie. the file system root (ie. "/").

Better still would be to use the actual item icon, as mentioned in comment #4.

Comment 9

[Jasper]

Attachment: A small local file icon (tiny 16/16 px flatpanel iMac).

As requested in Comment #8.

Comment 10

[Mark Knopper]

In Camino Build ID: 2003090102, bookmark icons for network URLs and file URLs
still look the same. It would be great if Pink's suggestion in #4 (get file icon
from the Finder) could be implemented.

Comment 11

[Ben]

another thing that would be nice is if camino  had some urlbar feature that
tells you if a local file exists at the current location.  For example, safari
will change the icon to the file's icon in the finder if you've typed in a
location that exists, but uses a generic one otherwise.

Comment 12

[Samuel Sidler (old account; do not CC)]

Is there anything stopping us from checking this in? It seems easy enough.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We already have a very nice blank "document" icon (open a new, blank tab and see
it), but presumably there's code needed to make it display for file:/// urls.

Comment 14

[Wevah (Nate Weaver)]

Could we instead ask NSWorkspace for the file's actual icon?

Comment 15

[Simon Fraser [no longer active]]

(In reply to comment #14)
> Could we instead ask NSWorkspace for the file's actual icon?

I think this would be really slow, and as far as I can tell, it leaks like a
sieve (we use it for downloads).

Comment 16

[Simon Fraser [no longer active]]

Attachment: Patch

Comment 17

[Simon Fraser [no longer active]]

Fixed on branch and trunk.