1568900 - Hide "Change Block List" UI in Custom option of ETP

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P3)

Description

[Maxx Crawford [:maxx]]

Hide "Change Block List" ui in Custom option of ETP behind pref: browser.contentblocking.customBlockList.preferences.ui.enabled;true

Documentation Links:
UX: https://mozilla.invisionapp.com/share/QWT0UQ5APET#/371154741_Preferences
Strings: https://docs.google.com/presentation/d/14-AIQWnDDHO1pYhHDZffJ2x4gWT7VkCSkb-X3ghmfKA

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

What's logical rationale for this change? Hiding preferences in about:config doesn't seem overall like good idea, as how user will know about this that some hidden preference control this and firstly user need to unhide it by changing something.

Comment 2

[Maxx Crawford [:maxx]]

Part of this feature includes logic to show the Block List UI option to any user who currently has something outside of the default set.

Tagging people who can speak more to why this is being hidden: [:tanvi] [:johannah] [:chsiang]

Comment 3

[Johann Hofmann [:johannh]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #1)

What's logical rationale for this change? Hiding preferences in about:config doesn't seem overall like good idea, as how user will know about this that some hidden preference control this and firstly user need to unhide it by changing something.

We are looking to deprecate the strict/L2 list setting for TP, mid-term. Our strategy for privacy protections in Firefox is centered around gradually improving default protections for everyone, with only the minimum necessary breakage. The amount of breakage caused by the L2 TP list means there is almost no chance it will ever be part of the "standard" or even "strict" content blocking settings.

Lacking such perspective, should we keep this list as a permanent setting for advanced users in "Custom"? No, in my opinion. I don't consider block list management an essential browser feature, like, say, restricting cookie and site data access. The current block list management in Firefox preferences is terrible for a "pro-user" feature, and there are great tools like uBlock and uMatrix that have advanced options for managing block lists.

Short term, we would like to reduce exposure of this setting to users. As Maxx mentions, anyone with custom block list setting will still see this UI in order to be able to revert their strict settings to default.

Comment 4

[Maxx Crawford [:maxx]]

Attachment: Bug 1568900 - Hide "Change Block List" UI in Custom option of ETP r=johannh

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3aa2c4bb3942b8d6cec5c94987ae0f8fffe472c3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/761cbe842150
Hide "Change Block List" UI in Custom option of ETP r=johannh

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/761cbe842150