1569046 - Support bootstrapping OS X development environments with Python 3

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Māris Fogels [:mars] (please needinfo)]

We need to support bootstrapping an OS X development environment in Python 3.6+ as well as Python 2.7.

This bug involves porting and testing the mozboot.osx module with both Python 2.7 and Python 3.6+. Adding Python 3 support to the rest of the mozboot package is covered by other bugs.

Whoever works on this bug will have to test for successful bootstrapping of all four of the application development environment types given by the bootstrap.py script: browser, browser_artifact_mode, mobile, and mobile_artifact_mode.

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Attachment: Bug 1569046 - Add Python 3 support to mozboot.osx r?#build

Make the mozboot.osx module work with Python 3 in addition to
Python 2.7.

Comment 2

[Māris Fogels [:mars] (please needinfo)]

I've taken on the task of writing the port, :mshal has taken on the testing because I don't have an OS X box.

Here is the tip of the try branch containing changes to mozboot.osx we are testing. (The branch includes a bunch of other changes to make 'mach bootstrap' run under Python 3.) https://hg.mozilla.org/try/rev/a389cf7b2986502c376523af6ebe3f3c32f07988

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/975727f55b82
Add Python 3 support to mozboot.osx r=firefox-build-system-reviewers,mshal

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 8 changesets (Bug 1569046, Bug 1210157) for flake8 failure on base.py

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linting%2Copt%2Csource-test-mozlint-py-flake8%2C%28f8%29&fromchange=a59737bc6d819c1a9da579977c1afe6145964690&tochange=3c49b0c27b1558011f0927f6169fa522b2117c04

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c49b0c27b1558011f0927f6169fa522b2117c04

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262549430&repo=autoland&lineNumber=288
[task 2019-08-20T21:03:03.028Z] building 'psutil._psutil_posix' extension
[task 2019-08-20T21:03:03.028Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-08-20T21:03:03.028Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-08-20T21:03:03.028Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-08-20T21:03:03.028Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-08-20T21:03:03.028Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-08-20T21:03:03.029Z]
[task 2019-08-20T21:03:03.029Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-08-20T21:06:15.592Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozboot/mozboot/base.py:27:1 | too many blank lines (3) (E303)
[taskcluster 2019-08-20 21:06:16.128Z] === Task Finished ===
[taskcluster 2019-08-20 21:06:17.135Z] Unsuccessful task run with exit code: 1 completed in 462.916 seconds

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ddb34b933f3
Add Python 3 support to mozboot.osx r=firefox-build-system-reviewers,mshal

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5ddb34b933f3