1569059 - [mach] Run 'mach bootstrap' with Python 3

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Māris Fogels [:mars] (please needinfo)]

The mach script supports running commands in either Python 2 or Python 3, depending on whether the command has been made Python 3-compatible. Once the bootstrap.py script or the mach bootstrap command has been shown to work in Linux, OS X, and Windows, then we can edit the mach script and tell it to run mach bootstrap with Python 3 instead of Python 2.

This bug tracks the work to make the switch in the mach script itself and to track work that has to happen before the switch can be made. The work to port the bootstrappers for each of the OSes is covered in other bugs.

Comment 1

[rudazz]

Attachment: patch to fix the bootstrap script on python3 (open the file in text mode instead of bynary mode)

I just bumped on this issue when trying to checkout the mozilla-central in a system were the default python interpreter is python3. I've tested it on python2 and it also worked fine.

Comment 2

[rudazz]

Just to be clear, this is the error I've fixed with this patch:

Would you like to clone to './mozilla-unified' instead?
  1. Yes
  2. No, let me enter another path
  3. No, stop cloning
Your choice: 1
Cloning Firefox Mercurial repository to ./mozilla-unified
Traceback (most recent call last):
  File "bootstrap.py", line 194, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 185, in main
    dasboot.bootstrap()
  File "/tmp/tmp87bye9py/mozboot/bootstrap.py", line 484, in bootstrap
  File "/tmp/tmp87bye9py/mozboot/bootstrap.py", line 605, in hg_clone_firefox
TypeError: a bytes-like object is required, not 'str'

Comment 3

[Karan Sapolia]

Is this fixed? I am still getting this error with Python3

Cloning Firefox Mercurial repository to mozilla-unified
Traceback (most recent call last):
  File "bootstrap.py", line 194, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 185, in main
    dasboot.bootstrap()
  File "/tmp/tmp5oie306d/mozboot/bootstrap.py", line 497, in bootstrap
  File "/tmp/tmp5oie306d/mozboot/bootstrap.py", line 618, in hg_clone_firefox
TypeError: a bytes-like object is required, not 'str'

Mercurial version: 4.9.0
Python version: 3.7.5
OS: Fedora 31

Comment 4

[Māris Fogels [:mars] (please needinfo)]

Hi Karan, the fix for that error landed in the last 48 hours. See bug 1606955.

Comment 5

[Ricky Stewart]

Attachment: Bug 1569059 - Run 'mach bootstrap' with Python 3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/3ebc1bfe6d20
Run 'mach bootstrap' with Python 3 r=firefox-build-system-reviewers,mshal,Callek

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3ebc1bfe6d20