Closed Bug 1569070 Opened 6 years ago Closed 5 years ago

[lando-api] Write a comment with the sanitized commit message back to Phabricator

Categories

(Conduit :: Lando, task, P2)

Product:
Conduit
Component:
Lando
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mars, Assigned: mars)

References

(Blocks 1 open bug)

Details

(Keywords: conduit-triaged)

When an API client has requested sec-approval for a sanitized commit message the message must be written back to Phabricator as a comment for review by the sec-approval project.

Initial notes and acceptance criteria:

  • Submit sanitized message to API
  • Phabricator comment template
  • Mechanism to prevent spoofing, tampering, or mangling of the message in the Phabricator comment
  • Helpful user text: where this came from (a bot), please don't touch this comment, link to process in the wiki.
  • PhabricatorClient method to add comments to phabricator revisions
  • Synchronous call
    • Single request to Phabricator if possible
    • Return HTTP 502 to the lando API client if downstream (Phabricator) is not available
Assignee: nobody → mars
Status: NEW → ASSIGNED
Keywords: conduit-triaged
Priority: -- → P2
Depends on: 1574600

This has been deployed to dev. It's waiting for the lando-ui component to land so it can be tested. https://whatsdeployed.io/s/46t/mozilla-conduit/lando-api

I've verified the code works on dev.

Depends on: 1596651

This has been deployed to production.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.