Closed Bug 1569071 Opened 6 years ago Closed 5 years ago

[lando-api] Add the sec-approval team as a blocking reviewer when API clients request sec-approval

Categories

(Conduit :: Lando, task, P2)

Product:
Conduit
Component:
Lando
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mars, Assigned: mars)

References

(Blocks 1 open bug)

Details

(Keywords: conduit-triaged)

When an API client requests sec-approval for a message, once that message is posted back to Phabricator we should add the sec-approval team as a blocking reviewer for the revision. The sec-approval team will then know that they have a new commit message to review. They can use the Phabricator Accept Revision option to approve the sanitized commit message.

Rough notes:

  • PhabricatorClient API method to set blocking reviewers?
  • What do we do if the sec-approval group is missing or the 'add reviewer' Phabricator API call fails in some other way?
  • Is the sec-approval group name hard-coded or some other form of static configuration?
Depends on: 1574600

This has been deployed to dev. It's waiting for the lando-ui component to land so it can be tested. https://whatsdeployed.io/s/46t/mozilla-conduit/lando-api

I've verified the code works on dev.

Depends on: 1596651

This has been deployed to production.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.